From: no-reply@patchew.org
To: yamamoto@midokura.com
Cc: qemu-devel@nongnu.org, yamamoto@midokura.com
Subject: Re: [PATCH v2 00/11] linux-user changes to run docker
Date: Sun, 30 May 2021 23:07:25 -0700 (PDT) [thread overview]
Message-ID: <162244124398.30167.9625522115700719754@0addf061776e> (raw)
In-Reply-To: <20210531055019.10149-1-yamamoto@midokura.com>
Patchew URL: https://patchew.org/QEMU/20210531055019.10149-1-yamamoto@midokura.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210531055019.10149-1-yamamoto@midokura.com
Subject: [PATCH v2 00/11] linux-user changes to run docker
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9266033 linux-user: always assume preserve_argv0 for now [!MERGE]
c47e5f7 linux-user: a crude hack for libcontainer (CLONE_PARENT) [!MERGE]
3918e1b linux-user: Make the qemu detection for /proc/$pid/exe a bit conservative
c085fdc linux-user: Implement exec of /proc/$pid/exe of qemu process
1183bf9 linux-user: simplify is_proc_myself
3d2e26d linux-user: add get_exe_path
4468f68 linux-user: Implement pivot_root
42242cc linux-user: make exec_path realpath
057e7e4 linux-user: dup the execfd on start up
187d6d2 linux-user: Fix the execfd case of /proc/self/exe open
02ef5e5 linux-user: handle /proc/self/exe for execve
=== OUTPUT BEGIN ===
1/11 Checking commit 02ef5e5d9e50 (linux-user: handle /proc/self/exe for execve)
2/11 Checking commit 187d6d29d488 (linux-user: Fix the execfd case of /proc/self/exe open)
3/11 Checking commit 057e7e49d4fe (linux-user: dup the execfd on start up)
4/11 Checking commit 42242cc0513b (linux-user: make exec_path realpath)
5/11 Checking commit 4468f68480f3 (linux-user: Implement pivot_root)
WARNING: architecture specific defines should be avoided
#23: FILE: linux-user/syscall.c:8257:
+#if defined(TARGET_NR_pivot_root) && defined(__NR_pivot_root)
total: 0 errors, 1 warnings, 33 lines checked
Patch 5/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/11 Checking commit 3d2e26daa82e (linux-user: add get_exe_path)
7/11 Checking commit 1183bf9702cb (linux-user: simplify is_proc_myself)
8/11 Checking commit c085fdc89c7c (linux-user: Implement exec of /proc/$pid/exe of qemu process)
9/11 Checking commit 3918e1b7eee5 (linux-user: Make the qemu detection for /proc/$pid/exe a bit conservative)
10/11 Checking commit c47e5f77ef07 (linux-user: a crude hack for libcontainer (CLONE_PARENT) [!MERGE])
11/11 Checking commit 9266033e47cb (linux-user: always assume preserve_argv0 for now [!MERGE])
ERROR: if this code is redundant consider removing it
#26: FILE: linux-user/main.c:729:
+#if 0
total: 1 errors, 0 warnings, 38 lines checked
Patch 11/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210531055019.10149-1-yamamoto@midokura.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2021-05-31 6:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 5:50 [PATCH v2 00/11] linux-user changes to run docker YAMAMOTO Takashi
2021-05-31 5:50 ` [PATCH v2 01/11] linux-user: handle /proc/self/exe for execve YAMAMOTO Takashi
2021-06-20 14:14 ` Laurent Vivier
2021-06-21 2:02 ` Takashi Yamamoto
2021-06-22 13:47 ` Laurent Vivier
2021-05-31 5:50 ` [PATCH v2 02/11] linux-user: Fix the execfd case of /proc/self/exe open YAMAMOTO Takashi
2021-06-20 14:16 ` Laurent Vivier
2021-06-21 1:19 ` Takashi Yamamoto
2021-05-31 5:50 ` [PATCH v2 03/11] linux-user: dup the execfd on start up YAMAMOTO Takashi
2021-05-31 5:50 ` [PATCH v2 04/11] linux-user: make exec_path realpath YAMAMOTO Takashi
2021-05-31 5:50 ` [PATCH v2 05/11] linux-user: Implement pivot_root YAMAMOTO Takashi
2021-06-20 14:02 ` Laurent Vivier
2021-06-20 14:05 ` Laurent Vivier
2021-05-31 5:50 ` [PATCH v2 06/11] linux-user: add get_exe_path YAMAMOTO Takashi
2021-05-31 5:50 ` [PATCH v2 07/11] linux-user: simplify is_proc_myself YAMAMOTO Takashi
2021-05-31 5:50 ` [PATCH v2 08/11] linux-user: Implement exec of /proc/$pid/exe of qemu process YAMAMOTO Takashi
2021-05-31 5:50 ` [PATCH v2 09/11] linux-user: Make the qemu detection for /proc/$pid/exe a bit conservative YAMAMOTO Takashi
2021-05-31 5:50 ` [PATCH v2 10/11] linux-user: a crude hack for libcontainer (CLONE_PARENT) [!MERGE] YAMAMOTO Takashi
2021-05-31 5:50 ` [PATCH v2 11/11] linux-user: always assume preserve_argv0 for now [!MERGE] YAMAMOTO Takashi
2021-05-31 6:07 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162244124398.30167.9625522115700719754@0addf061776e \
--to=no-reply@patchew.org \
--cc=qemu-devel@nongnu.org \
--cc=yamamoto@midokura.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).