qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: mcascell@redhat.com
Cc: mcascell@redhat.com, yuval.shaia.ml@gmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] Test comment for git-publish
Date: Mon, 14 Jun 2021 15:30:29 -0700 (PDT)	[thread overview]
Message-ID: <162370982844.2358.7497742131893674982@7c66fb7bc3ab> (raw)
In-Reply-To: <20210611164305.440633-1-mcascell@redhat.com>

Patchew URL: https://patchew.org/QEMU/20210611164305.440633-1-mcascell@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210611164305.440633-1-mcascell@redhat.com
Subject: [PATCH v2] Test comment for git-publish

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
bf784f4 Test comment for git-publish

=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#21: FILE: hw/rdma/vmw/pvrdma_main.c:430:
+            pvrdma_exec_cmd(dev); // this is a test comment

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 0 warnings, 8 lines checked

Commit bf784f48ac5f (Test comment for git-publish) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210611164305.440633-1-mcascell@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

      parent reply	other threads:[~2021-06-14 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 16:43 [PATCH v2] Test comment for git-publish Mauro Matteo Cascella
2021-06-11 17:11 ` Mauro Matteo Cascella
2021-06-14 22:30 ` no-reply [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162370982844.2358.7497742131893674982@7c66fb7bc3ab \
    --to=no-reply@patchew.org \
    --cc=mcascell@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yuval.shaia.ml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).