Re: [PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210623142245.307776-1-berrange@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210623142245.307776-1-berrange@redhat.com
Subject: [PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210622154820.1978982-1-richard.henderson@linaro.org -> patchew/20210622154820.1978982-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210623142245.307776-1-berrange@redhat.com -> patchew/20210623142245.307776-1-berrange@redhat.com
Switched to a new branch 'test'
9758826 tests/docker: remove ubuntu container
ef3ef4e tests/docker: auto-generate opensuse-leap with lcitool
895aed9 tests/docker: auto-generate ubuntu2004 with lcitool
2119de5 tests/docker: auto-generate ubuntu1804 with lcitool
03e1cd3 tests/docker: auto-generate fedora with lcitool
c62c731 tests/docker: auto-generate centos8 with lcitool
d64ab33 tests/docker: add script for automating container refresh
c2baddd tests/docker: expand opensuse-leap package list
3dd08f6 tests/docker: expand ubuntu2004 package list
0b1a6dd tests/docker: expand ubuntu1804 package list
e518827 tests/docker: expand fedora package list
d19b072 tests/docker: expand centos8 package list
e281ae9 tests/docker: remove mingw packages from Fedora
574be70 tests/docker: fix mistakes in ubuntu package lists
88cd410 tests/docker: fix mistakes in fedora package list
bfc10c9 tests/docker: fix mistakes in centos package lists
4c6b851 tests/docker: fix sorting in package lists
f923bf8 tests/docker: remove FEATURES env var from templates
6ba5000 tests/docker: use explicit docker.io registry
c579052 tests/docker: use project specific container registries
7bd0b09 tests/docker: don't use BUILDKIT in GitLab either
155fe73 hw/usb/ccid: remove references to NSS

=== OUTPUT BEGIN ===
1/22 Checking commit 155fe7320a76 (hw/usb/ccid: remove references to NSS)
2/22 Checking commit 7bd0b09da0eb (tests/docker: don't use BUILDKIT in GitLab either)
3/22 Checking commit c5790521a51c (tests/docker: use project specific container registries)
4/22 Checking commit 6ba5000cb228 (tests/docker: use explicit docker.io registry)
5/22 Checking commit f923bf8c6a02 (tests/docker: remove FEATURES env var from templates)
6/22 Checking commit 4c6b85101644 (tests/docker: fix sorting in package lists)
7/22 Checking commit bfc10c97c4b9 (tests/docker: fix mistakes in centos package lists)
8/22 Checking commit 88cd410064a6 (tests/docker: fix mistakes in fedora package list)
9/22 Checking commit 574be70f0bbe (tests/docker: fix mistakes in ubuntu package lists)
10/22 Checking commit e281ae966f35 (tests/docker: remove mingw packages from Fedora)
11/22 Checking commit d19b07286aaa (tests/docker: expand centos8 package list)
12/22 Checking commit e518827eb832 (tests/docker: expand fedora package list)
13/22 Checking commit 0b1a6dd81adf (tests/docker: expand ubuntu1804 package list)
14/22 Checking commit 3dd08f63b4f6 (tests/docker: expand ubuntu2004 package list)
15/22 Checking commit c2baddde6702 (tests/docker: expand opensuse-leap package list)
16/22 Checking commit d64ab332097d (tests/docker: add script for automating container refresh)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#114: 
new file mode 100755

total: 0 errors, 1 warnings, 123 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit c62c7311eed8 (tests/docker: auto-generate centos8 with lcitool)
18/22 Checking commit 03e1cd3c038c (tests/docker: auto-generate fedora with lcitool)
19/22 Checking commit 2119de590b58 (tests/docker: auto-generate ubuntu1804 with lcitool)
20/22 Checking commit 895aed9013c2 (tests/docker: auto-generate ubuntu2004 with lcitool)
ERROR: line over 90 characters
#28: FILE: tests/docker/dockerfiles-refresh.py:65:
+               "RUN sed -i 's/^const/static const/g' /usr/lib/llvm-10/lib/clang/10.0.0/include/sanitizer/tsan_interface.h\n"]

total: 1 errors, 0 warnings, 270 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

21/22 Checking commit ef3ef4e88131 (tests/docker: auto-generate opensuse-leap with lcitool)
22/22 Checking commit 975882640606 (tests/docker: remove ubuntu container)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
deleted file mode 100644

total: 0 errors, 1 warnings, 11 lines checked

Patch 22/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210623142245.307776-1-berrange@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com