From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66DDBC433EF for ; Tue, 26 Oct 2021 11:14:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D298D60238 for ; Tue, 26 Oct 2021 11:14:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D298D60238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ispras.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfKPQ-0008VS-UF for qemu-devel@archiver.kernel.org; Tue, 26 Oct 2021 07:14:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfJk1-0006YN-FH for qemu-devel@nongnu.org; Tue, 26 Oct 2021 06:31:37 -0400 Received: from mail.ispras.ru ([83.149.199.84]:39288) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfJjy-00050Q-1T for qemu-devel@nongnu.org; Tue, 26 Oct 2021 06:31:37 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 0846540A2BAE; Tue, 26 Oct 2021 10:31:22 +0000 (UTC) Subject: [PATCH] hw/net: store timers for e1000 in vmstate From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Tue, 26 Oct 2021 13:31:21 +0300 Message-ID: <163524428177.1917083.7115508068018047923.stgit@pasha-ThinkPad-X280> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=83.149.199.84; envelope-from=pavel.dovgalyuk@ispras.ru; helo=mail.ispras.ru X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jasowang@redhat.com, pavel.dovgalyuk@ispras.ru, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Setting timers randomly when vmstate is loaded breaks execution determinism. Therefore this patch allows saving mit and autoneg timers for e1000. It makes execution deterministic and allows snapshotting and reverse debugging in icount mode. Signed-off-by: Pavel Dovgalyuk --- hw/net/e1000.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 50 insertions(+), 11 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index a30546c5d5..2f706f7298 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -37,6 +37,7 @@ #include "qemu/iov.h" #include "qemu/module.h" #include "qemu/range.h" +#include "sysemu/replay.h" #include "e1000x_common.h" #include "trace.h" @@ -1407,7 +1408,7 @@ static int e1000_pre_save(void *opaque) * complete auto-negotiation immediately. This allows us to look * at MII_SR_AUTONEG_COMPLETE to infer link status on load. */ - if (nc->link_down && have_autoneg(s)) { + if (replay_mode == REPLAY_MODE_NONE && nc->link_down && have_autoneg(s)) { s->phy_reg[PHY_STATUS] |= MII_SR_AUTONEG_COMPLETE; } @@ -1438,22 +1439,12 @@ static int e1000_post_load(void *opaque, int version_id) s->mac_reg[TADV] = 0; s->mit_irq_level = false; } - s->mit_ide = 0; - s->mit_timer_on = true; - timer_mod(s->mit_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 1); /* nc.link_down can't be migrated, so infer link_down according * to link status bit in mac_reg[STATUS]. * Alternatively, restart link negotiation if it was in progress. */ nc->link_down = (s->mac_reg[STATUS] & E1000_STATUS_LU) == 0; - if (have_autoneg(s) && - !(s->phy_reg[PHY_STATUS] & MII_SR_AUTONEG_COMPLETE)) { - nc->link_down = false; - timer_mod(s->autoneg_timer, - qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + 500); - } - s->tx.props = s->mig_props; if (!s->received_tx_tso) { /* We received only one set of offload data (tx.props) @@ -1472,6 +1463,13 @@ static int e1000_tx_tso_post_load(void *opaque, int version_id) return 0; } +static int e1000_mit_timer_post_load(void *opaque, int version_id) +{ + E1000State *s = opaque; + s->mit_timer_on = true; + return 0; +} + static bool e1000_mit_state_needed(void *opaque) { E1000State *s = opaque; @@ -1493,6 +1491,21 @@ static bool e1000_tso_state_needed(void *opaque) return chkflag(TSO); } +static bool e1000_mit_timer_needed(void *opaque) +{ + E1000State *s = opaque; + + return s->mit_timer_on; +} + +static bool e1000_autoneg_timer_needed(void *opaque) +{ + E1000State *s = opaque; + + return have_autoneg(s) + && !(s->phy_reg[PHY_STATUS] & MII_SR_AUTONEG_COMPLETE); +} + static const VMStateDescription vmstate_e1000_mit_state = { .name = "e1000/mit_state", .version_id = 1, @@ -1541,6 +1554,30 @@ static const VMStateDescription vmstate_e1000_tx_tso_state = { } }; +static const VMStateDescription vmstate_e1000_mit_timer = { + .name = "e1000/mit_timer", + .version_id = 1, + .minimum_version_id = 1, + .needed = e1000_mit_timer_needed, + .post_load = e1000_mit_timer_post_load, + .fields = (VMStateField[]) { + VMSTATE_TIMER_PTR(mit_timer, E1000State), + VMSTATE_UINT32(mit_ide, E1000State), + VMSTATE_END_OF_LIST() + } +}; + +static const VMStateDescription vmstate_e1000_autoneg_timer = { + .name = "e1000/autoneg_timer", + .version_id = 1, + .minimum_version_id = 1, + .needed = e1000_autoneg_timer_needed, + .fields = (VMStateField[]) { + VMSTATE_TIMER_PTR(autoneg_timer, E1000State), + VMSTATE_END_OF_LIST() + } +}; + static const VMStateDescription vmstate_e1000 = { .name = "e1000", .version_id = 2, @@ -1622,6 +1659,8 @@ static const VMStateDescription vmstate_e1000 = { &vmstate_e1000_mit_state, &vmstate_e1000_full_mac_state, &vmstate_e1000_tx_tso_state, + &vmstate_e1000_mit_timer, + &vmstate_e1000_autoneg_timer, NULL } };