qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Ziqiao Kong <ziqiaokong@gmail.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, ehabkost@redhat.com
Subject: Re: [PATCH v7 1/2] target/i386: Trivial code motion and code style fix
Date: Wed, 7 Jul 2021 14:01:10 -0700	[thread overview]
Message-ID: <1647d7e2-2ea0-f7bb-6cfc-92c56f9e11ae@linaro.org> (raw)
In-Reply-To: <20210530150112.74411-1-ziqiaokong@gmail.com>

On 5/30/21 8:01 AM, Ziqiao Kong wrote:
> A new pair of braces has to be added to declare variables in the case block.
> The code style is also fixed according to the transalte.c itself during the
> code motion.
> 
> Signed-off-by: Ziqiao Kong<ziqiaokong@gmail.com>
> ---
> Sorry for the duplicate emails due to my bad network. The v7 has no
> difference from v6 and is sent just for clarification.
> Changes since v5:
> - None
> Changes since v4:
> - Rewrite commit message to specify the reason to add the braces.
> ---
>   target/i386/tcg/translate.c | 957 ++++++++++++++++++------------------
>   1 file changed, 484 insertions(+), 473 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


      parent reply	other threads:[~2021-07-07 21:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-30 15:01 [PATCH v7 1/2] target/i386: Trivial code motion and code style fix Ziqiao Kong
2021-05-30 15:01 ` [PATCH v7 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP Ziqiao Kong
2021-06-04 15:04   ` Ziqiao Kong
2021-06-11 14:32     ` Ziqiao Kong
2021-06-24 17:06       ` Ziqiao Kong
2021-07-01 13:58         ` Ziqiao Kong
2021-07-06 14:20           ` Ziqiao Kong
2021-07-06 22:20   ` Eduardo Habkost
2021-07-07 21:08   ` Richard Henderson
2021-06-04 15:04 ` [PATCH v7 1/2] target/i386: Trivial code motion and code style fix Ziqiao Kong
2021-06-11 14:32   ` Ziqiao Kong
2021-06-24 17:06     ` Ziqiao Kong
2021-07-01 13:58       ` Ziqiao Kong
2021-07-06 14:20         ` Ziqiao Kong
2021-07-07 21:01 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1647d7e2-2ea0-f7bb-6cfc-92c56f9e11ae@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ziqiaokong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).