From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Marek Vasut <marex@denx.de>, Chris Wulff <crwulff@gmail.com>,
Joe Komlodi <komlodi@xilinx.com>
Subject: Re: [PATCH 2/2] target/nios2: Use MMUAccessType enum type when possible
Date: Wed, 3 Feb 2021 16:45:06 -1000 [thread overview]
Message-ID: <1738e3da-7b19-dd69-9e76-a1bf4af404ce@linaro.org> (raw)
In-Reply-To: <20210127234119.3537399-3-f4bug@amsat.org>
On 1/27/21 1:41 PM, Philippe Mathieu-Daudé wrote:
> All callers of mmu_translate() provide it a MMUAccessType
> type. Let the prototype use it as argument, as it is stricter
> than an integer. We can remove the documentation as enum
> names are self explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/nios2/mmu.h | 3 ++-
> target/nios2/mmu.c | 4 ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2021-02-04 3:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 23:41 [PATCH 0/2] target/nios2: Pass MMUAccessType to mmu_translate() Philippe Mathieu-Daudé
2021-01-27 23:41 ` [PATCH 1/2] target/nios2: Replace magic value by MMU definitions Philippe Mathieu-Daudé
2021-02-04 2:44 ` Richard Henderson
2021-01-27 23:41 ` [PATCH 2/2] target/nios2: Use MMUAccessType enum type when possible Philippe Mathieu-Daudé
2021-02-04 2:45 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1738e3da-7b19-dd69-9e76-a1bf4af404ce@linaro.org \
--to=richard.henderson@linaro.org \
--cc=crwulff@gmail.com \
--cc=f4bug@amsat.org \
--cc=komlodi@xilinx.com \
--cc=marex@denx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).