From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Chenyi Qiang <chenyi.qiang@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [RFC PATCH] i386: Add ratelimit for bus locks acquired in guest
Date: Fri, 19 Mar 2021 09:23:49 +0800 [thread overview]
Message-ID: <1760f09a-fc0c-047e-c38b-8180e4f23517@intel.com> (raw)
In-Reply-To: <20210317084709.15605-1-chenyi.qiang@intel.com>
On 3/17/2021 4:47 PM, Chenyi Qiang wrote:
[...]
> MemTxAttrs kvm_arch_post_run(CPUState *cpu, struct kvm_run *run)
> {
> X86CPU *x86_cpu = X86_CPU(cpu);
> @@ -4236,6 +4271,11 @@ MemTxAttrs kvm_arch_post_run(CPUState *cpu, struct kvm_run *run)
> } else {
> env->eflags &= ~IF_MASK;
> }
> + if (run->flags & KVM_RUN_X86_BUS_LOCK) {
> + kvm_cpu_synchronize_state(cpu);
> + warn_report("bus lock detected at rip: 0x%lx", env->eip);
Chenyi,
Let's drop the eip here since QEMU has no idea whether it points to the
next instruction or the exact instruction acquires bus lock.
> + kvm_rate_limit_on_bus_lock();
> + }
>
> /* We need to protect the apic state against concurrent accesses from
> * different threads in case the userspace irqchip is used. */
> @@ -4594,6 +4634,10 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run)
> ioapic_eoi_broadcast(run->eoi.vector);
> ret = 0;
> break;
> + case KVM_EXIT_X86_BUS_LOCK:
> + /* already handled in kvm_arch_post_run */
> + ret = 0;
> + break;
> default:
> fprintf(stderr, "KVM: unknown exit reason %d\n", run->exit_reason);
> ret = -1;
>
next prev parent reply other threads:[~2021-03-19 1:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 8:47 [RFC PATCH] i386: Add ratelimit for bus locks acquired in guest Chenyi Qiang
2021-03-18 17:32 ` Marcelo Tosatti
2021-03-19 2:59 ` Chenyi Qiang
2021-03-19 3:16 ` Xiaoyao Li
2021-03-19 12:37 ` Marcelo Tosatti
2021-03-22 4:11 ` Chenyi Qiang
2021-03-19 1:23 ` Xiaoyao Li [this message]
2021-03-19 3:05 ` Chenyi Qiang
2021-04-01 4:19 ` Chenyi Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1760f09a-fc0c-047e-c38b-8180e4f23517@intel.com \
--to=xiaoyao.li@intel.com \
--cc=chenyi.qiang@intel.com \
--cc=ehabkost@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).