From: Vijai Kumar K <vijai@behindbytes.com>
To: "Alistair Francis" <alistair23@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 4/4] hw/riscv: Connect Shakti UART to Shakti platform
Date: Fri, 02 Apr 2021 21:11:01 +0530 [thread overview]
Message-ID: <178933eacf0.29d40a5748832.4360448576483328617@behindbytes.com> (raw)
In-Reply-To: <CAKmqyKPCbBznWkOeREnb-r7gHbzhvvjBXafNYkBT1u52+9z7hQ@mail.gmail.com>
---- On Fri, 02 Apr 2021 18:35:04 +0530 Alistair Francis <alistair23@gmail.com> wrote ----
> On Thu, Apr 1, 2021 at 2:15 PM Vijai Kumar K <vijai@behindbytes.com> wrote:
> >
> > Connect one shakti uart to the shakti_c machine.
> >
> > Signed-off-by: Vijai Kumar K <vijai@behindbytes.com>
>
> In future can you please keep the Reviewed by tags when sending a new
> version of the patch series?
Yes. My bad. Sorry about that.
Thanks,
Vijai Kumar K
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>
> Alistair
>
> > ---
> > hw/riscv/shakti_c.c | 8 ++++++++
> > include/hw/riscv/shakti_c.h | 2 ++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c
> > index c8205d3f22..e207fa83dd 100644
> > --- a/hw/riscv/shakti_c.c
> > +++ b/hw/riscv/shakti_c.c
> > @@ -125,6 +125,13 @@ static void shakti_c_soc_state_realize(DeviceState *dev, Error **errp)
> > SIFIVE_SIP_BASE, SIFIVE_TIMECMP_BASE, SIFIVE_TIME_BASE,
> > SIFIVE_CLINT_TIMEBASE_FREQ, false);
> >
> > + qdev_prop_set_chr(DEVICE(&(sss->uart)), "chardev", serial_hd(0));
> > + if (!sysbus_realize(SYS_BUS_DEVICE(&sss->uart), errp)) {
> > + return;
> > + }
> > + sysbus_mmio_map(SYS_BUS_DEVICE(&sss->uart), 0,
> > + shakti_c_memmap[SHAKTI_C_UART].base);
> > +
> > /* ROM */
> > memory_region_init_rom(&sss->rom, OBJECT(dev), "riscv.shakti.c.rom",
> > shakti_c_memmap[SHAKTI_C_ROM].size, &error_fatal);
> > @@ -143,6 +150,7 @@ static void shakti_c_soc_instance_init(Object *obj)
> > ShaktiCSoCState *sss = RISCV_SHAKTI_SOC(obj);
> >
> > object_initialize_child(obj, "cpus", &sss->cpus, TYPE_RISCV_HART_ARRAY);
> > + object_initialize_child(obj, "uart", &sss->uart, TYPE_SHAKTI_UART);
> >
> > /*
> > * CPU type is fixed and we are not supporting passing from commandline yet.
> > diff --git a/include/hw/riscv/shakti_c.h b/include/hw/riscv/shakti_c.h
> > index 8ffc2b0213..50a2b79086 100644
> > --- a/include/hw/riscv/shakti_c.h
> > +++ b/include/hw/riscv/shakti_c.h
> > @@ -21,6 +21,7 @@
> >
> > #include "hw/riscv/riscv_hart.h"
> > #include "hw/boards.h"
> > +#include "hw/char/shakti_uart.h"
> >
> > #define TYPE_RISCV_SHAKTI_SOC "riscv.shakti.cclass.soc"
> > #define RISCV_SHAKTI_SOC(obj) \
> > @@ -33,6 +34,7 @@ typedef struct ShaktiCSoCState {
> > /*< public >*/
> > RISCVHartArrayState cpus;
> > DeviceState *plic;
> > + ShaktiUartState uart;
> > MemoryRegion rom;
> >
> > } ShaktiCSoCState;
> > --
> > 2.25.1
> >
> >
>
next prev parent reply other threads:[~2021-04-02 15:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 18:14 [PATCH v3 0/4] Add support for Shakti SoC from IIT-M Vijai Kumar K
2021-04-01 18:14 ` [PATCH v3 1/4] target/riscv: Add Shakti C class CPU Vijai Kumar K
2021-04-02 13:04 ` Alistair Francis
2021-04-01 18:14 ` [PATCH v3 2/4] riscv: Add initial support for Shakti C machine Vijai Kumar K
2021-04-02 13:03 ` Alistair Francis
2021-04-01 18:14 ` [PATCH v3 3/4] hw/char: Add Shakti UART emulation Vijai Kumar K
2021-04-02 16:12 ` Alistair Francis
2021-04-01 18:14 ` [PATCH v3 4/4] hw/riscv: Connect Shakti UART to Shakti platform Vijai Kumar K
2021-04-02 13:05 ` Alistair Francis
2021-04-02 15:41 ` Vijai Kumar K [this message]
2021-04-02 20:05 ` [PATCH v3 0/4] Add support for Shakti SoC from IIT-M Alistair Francis
2021-04-04 11:43 ` Vijai Kumar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178933eacf0.29d40a5748832.4360448576483328617@behindbytes.com \
--to=vijai@behindbytes.com \
--cc=alistair23@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).