From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8340C6377A for ; Thu, 22 Jul 2021 00:51:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E7156124B for ; Thu, 22 Jul 2021 00:51:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E7156124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Mvv-00039J-G6 for qemu-devel@archiver.kernel.org; Wed, 21 Jul 2021 20:51:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6Muc-0002Bn-Ph for qemu-devel@nongnu.org; Wed, 21 Jul 2021 20:50:06 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:45948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6Mua-00089H-CK for qemu-devel@nongnu.org; Wed, 21 Jul 2021 20:50:06 -0400 Received: by mail-pl1-x62e.google.com with SMTP id p17so2561176plf.12 for ; Wed, 21 Jul 2021 17:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=CiBs9ErOQVTYs2CjuygeJw6/bsE5JEbE2kWIVK2dJJs=; b=Mj30NXN5JoRRkJSVAttTcs4CLbG04ApmGv1dQL75q7zLJRaW6YZUDm42trvV75mg97 RljNZex1pdiPjD4E7yzT1WtSUUUImjyXtUUmWcWH4FYNMV3LM+P6IET5u8OChiwXL6eb UKzbKmeQJIbDsrb8vHmHzCqgnGv8XZXYT8HPisk8IpipKSoPUNZjMwUhghYsfOW9qBV8 l17RFnIeOX7GLoPFoXA8c2YZUmYdQ3hBX7CxS48jisMYB46HIUEWiQPbM3lysyrypPoP rXs5vIVmZycY6G0agDvYIlouZOLZzjbS1hBTcn3iXQw9lg7mIfg5YSAn+nLYDPFZPLX5 9/yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CiBs9ErOQVTYs2CjuygeJw6/bsE5JEbE2kWIVK2dJJs=; b=nrAOAqSixOhiKgncXw1bduWFIEu4gvwDvoZvVNHdodo9amlkvzkmxnV5s1wt7tnVOV Ph/lLQsfGPcLBWSf4a1NWHAVlDDXNfXiklfbMH9d35/F+ztAApGKEqIEwKEwqpZy1M0Z DwiZ4eeG7KdPREoBM5/6COXSPlM7MjiCp3+uk4VsnzLqjBQsjzoQEfIC/kXMG+qtK7fe wDYNFPOjGPOySy6OjM44ZFCLUroczFn9POI3LhsHO7SUX2AIG0Dhpjs/pC7M9BnyT3YD Cs8oFivyyX4Lomh29c3DQOsCcY7uMulWpqVXbu1uf6wNYwAJKV1CIkUXHdn939AnFpMy 4gvQ== X-Gm-Message-State: AOAM531KOof8Z22FeV1bgexdOtJ247ytHPtmgX+KFMHG8qQWLfGbplCX cSttN97hThXGX+ayzlIQVxAV92bBQc62/Q== X-Google-Smtp-Source: ABdhPJwFiDT4G+k2l73qOfP+Sz36kjTSPkOTepPW8ugf3swTXjD1sHqESrALXhQ2hmsjp8Cduu1BSg== X-Received: by 2002:a17:90a:3f87:: with SMTP id m7mr6436139pjc.128.1626915002590; Wed, 21 Jul 2021 17:50:02 -0700 (PDT) Received: from [192.168.3.43] (204-210-126-223.res.spectrum.com. [204.210.126.223]) by smtp.gmail.com with ESMTPSA id y187sm27716791pfb.185.2021.07.21.17.50.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 17:50:02 -0700 (PDT) Subject: Re: [PATCH for-6.2 33/34] target/arm: Implement MVE scatter-gather immediate forms To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210713133726.26842-1-peter.maydell@linaro.org> <20210713133726.26842-34-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <17a1f037-3033-dc83-e970-bb16dffcdeef@linaro.org> Date: Wed, 21 Jul 2021 14:49:59 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713133726.26842-34-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.117, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/13/21 3:37 AM, Peter Maydell wrote: > Implement the MVE VLDR/VSTR insns which do scatter-gather using base > addresses from Qm plus or minus an immediate offset (possibly with > writeback). Note that writeback is not predicated but it does have > to honour ECI state, so we have to add an eci_mask check to the > VSTR_SG macros (the VLDR_SG macros already needed this to be able > to distinguish "skip beat" from "set predicated element to 0"). > > Signed-off-by: Peter Maydell > --- > target/arm/helper-mve.h | 5 +++ > target/arm/mve.decode | 10 +++++ > target/arm/mve_helper.c | 91 ++++++++++++++++++++++++-------------- > target/arm/translate-mve.c | 66 +++++++++++++++++++++++++++ > 4 files changed, 140 insertions(+), 32 deletions(-) Reviewed-by: Richard Henderson r~