From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF05CC433DF for ; Sat, 30 May 2020 17:42:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1B7F206A1 for ; Sat, 30 May 2020 17:42:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jGIZhSR1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1B7F206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf5VC-0002SM-Sd for qemu-devel@archiver.kernel.org; Sat, 30 May 2020 13:42:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf5UK-0001sr-7S for qemu-devel@nongnu.org; Sat, 30 May 2020 13:41:40 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:29126 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jf5UI-0007D2-CI for qemu-devel@nongnu.org; Sat, 30 May 2020 13:41:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590860497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=C8+O4jKfZw2x6/nZ3z91acMOF/azKglpza49Rye/lx0=; b=jGIZhSR1G1gBSbZQzJVh3hYek9Xd5LCEuNR+SvTN11GU12XtnsozykfzL9S6rokml9GTvZ piU8bFEL6s+/XPSfjXtieCPZIZx8KS3Pc68fJkJcC+N8Nq28qktByU4svfneDEe/11EPrF 28DVa99q+BE/thv7rvx12iOzZhIYTUg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-lF9vksptM72L1wPVfZYQ8A-1; Sat, 30 May 2020 13:41:34 -0400 X-MC-Unique: lF9vksptM72L1wPVfZYQ8A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D293880B700; Sat, 30 May 2020 17:41:32 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-47.ams2.redhat.com [10.36.112.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0ADF710013C1; Sat, 30 May 2020 17:41:28 +0000 (UTC) Subject: Re: [PATCH] hw/display/cirrus_vga: Fix code mis-indentation To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200529165436.23573-1-f4bug@amsat.org> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <17c858f1-dbd0-42b9-f2fa-22954133891a@redhat.com> Date: Sat, 30 May 2020 19:41:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200529165436.23573-1-f4bug@amsat.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/30 12:03:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Peter Maydell , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 29/05/2020 18.54, Philippe Mathieu-Daudé wrote: > While replacing fprintf() by qemu_log_mask() in commit > 2b55f4d3504, we incorrectly used a 'tab = 4 spaces' > alignment, leading to misindented new code. Fix now. > > Reported-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/display/cirrus_vga.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c > index 92c197cdde..212d6f5e61 100644 > --- a/hw/display/cirrus_vga.c > +++ b/hw/display/cirrus_vga.c > @@ -1032,9 +1032,9 @@ static void cirrus_bitblt_start(CirrusVGAState * s) > } else { > if (s->cirrus_blt_mode & CIRRUS_BLTMODE_TRANSPARENTCOMP) { > if (s->cirrus_blt_pixelwidth > 2) { > - qemu_log_mask(LOG_GUEST_ERROR, > - "cirrus: src transparent without colorexpand " > - "must be 8bpp or 16bpp\n"); > + qemu_log_mask(LOG_GUEST_ERROR, > + "cirrus: src transparent without colorexpand " > + "must be 8bpp or 16bpp\n"); > goto bitblt_ignore; > } > if (s->cirrus_blt_mode & CIRRUS_BLTMODE_BACKWARDS) { > I think it would be better to fix the TABs in the whole surounding area, too. Or maybe even in the whole file. Otherwise this problem will happen soon again... Thomas