From: Richard Henderson <richard.henderson@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] tcg/tci: Implement INDEX_op_ld8s_i64
Date: Wed, 27 Jan 2021 12:55:56 -1000 [thread overview]
Message-ID: <19125e5e-c67f-2abd-ef70-72e96296a47d@linaro.org> (raw)
In-Reply-To: <20210127210737.2050633-1-sw@weilnetz.de>
On 1/27/21 11:07 AM, Stefan Weil wrote:
> case INDEX_op_ld8s_i64:
> - TODO();
> + t0 = *tb_ptr++;
> + t1 = tci_read_r(regs, &tb_ptr);
> + t2 = tci_read_s32(&tb_ptr);
> + tci_write_reg8(regs, t0, *(int8_t *)(t1 + t2));
> break;
This doesn't work, because tci_write_reg8 truncates to uint8_t again. You need
to use tci_write_reg().
r~
prev parent reply other threads:[~2021-01-27 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 21:07 [PATCH] tcg/tci: Implement INDEX_op_ld8s_i64 Stefan Weil
2021-01-27 22:55 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19125e5e-c67f-2abd-ef70-72e96296a47d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).