From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
pannengyuan@huawei.com
Cc: kwolf@redhat.com, liyiting@huawei.com,
zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, kuhn.chenqun@huawei.com
Subject: Re: [PATCH v5 1/2] block/nbd: extract the common cleanup code
Date: Tue, 25 Feb 2020 17:51:02 +0100 [thread overview]
Message-ID: <192ae73b-f9b9-3a25-c82d-6ef5b22a7f57@redhat.com> (raw)
In-Reply-To: <d5ff2791-0171-404b-3c19-69159921586b@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 722 bytes --]
On 05.12.19 15:04, Eric Blake wrote:
> On 12/5/19 3:42 AM, Stefano Garzarella wrote:
>> Hi Pan,
>>
>> On Thu, Dec 05, 2019 at 11:45:27AM +0800, pannengyuan@huawei.com wrote:
>>> From: Pan Nengyuan <pannengyuan@huawei.com>
>>>
>>> The BDRVNBDState cleanup code is common in two places, add
>>> nbd_clear_bdrvstate() function to do these cleanups.
>>>
>>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>>
>> I only suggested this change, so I think is better to change it in:
>> Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
>
> Concur. I'll make that change while queuing this series through my NBD
> tree for 5.0.
Ping on that O:)
(Just going through mails in my inbox)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-25 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 3:45 [PATCH v5 0/2] block/nbd: fix memory leak in nbd_open pannengyuan
2019-12-05 3:45 ` [PATCH v5 1/2] block/nbd: extract the common cleanup code pannengyuan
2019-12-05 9:42 ` Stefano Garzarella
2019-12-05 14:04 ` Eric Blake
2020-02-25 16:51 ` Max Reitz [this message]
2020-02-26 23:25 ` Eric Blake
2019-12-05 3:45 ` [PATCH v5 2/2] block/nbd: fix memory leak in nbd_open() pannengyuan
2019-12-05 9:45 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=192ae73b-f9b9-3a25-c82d-6ef5b22a7f57@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=kwolf@redhat.com \
--cc=liyiting@huawei.com \
--cc=pannengyuan@huawei.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).