From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57538C433ED for ; Fri, 14 May 2021 19:14:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14039613AA for ; Fri, 14 May 2021 19:14:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14039613AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhdGY-0005NC-7x for qemu-devel@archiver.kernel.org; Fri, 14 May 2021 15:14:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhdFT-00038b-NS for qemu-devel@nongnu.org; Fri, 14 May 2021 15:13:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhdFQ-0003dZ-SD for qemu-devel@nongnu.org; Fri, 14 May 2021 15:13:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621019600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e76bHY+MyoiN/DOUFIVW3ZG52FMuNkLcF4tb5TzdBGM=; b=M/6D7t1w4acCki3WcYX2gulYjd4dR+NScSYmrgDcks0ci904VFRiLCBmXlK5yL5n21UuFx 11LpScanv8iIVC1IaInwVye3tTbNLRJIViqH/Nto2WCWEg7HS6id33xcX2oQuU7lvV7waI QYc1d3fqK7G6BzNS5HyMbszmwdYaB+E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-553-G0OIaIZxMb-nTzjHe2nqpw-1; Fri, 14 May 2021 15:13:18 -0400 X-MC-Unique: G0OIaIZxMb-nTzjHe2nqpw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B842107ACCD; Fri, 14 May 2021 19:13:17 +0000 (UTC) Received: from [10.10.117.64] (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5E4F5D9CD; Fri, 14 May 2021 19:13:12 +0000 (UTC) Subject: Re: [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen To: Wainer dos Santos Moschetta , qemu-devel@nongnu.org References: <20210512214642.2803189-1-jsnow@redhat.com> <20210512214642.2803189-4-jsnow@redhat.com> <03a2e3c2-d5e6-de83-dc44-b9c9a4e4923f@redhat.com> From: John Snow Message-ID: <195efde7-1b0f-2d2f-d028-c8c2ada3318c@redhat.com> Date: Fri, 14 May 2021 15:13:11 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <03a2e3c2-d5e6-de83-dc44-b9c9a4e4923f@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Cleber Rosa , Eduardo Habkost , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/14/21 10:08 AM, Wainer dos Santos Moschetta wrote: > Now it might throw a CalledProcessError given that `check=True`. > Shouldn't it capture the exception and (possible) re-throw as an > QEMUMachineError? I lied to you again. The existing callers all check for failure explicitly, so in the interest of avoiding an API change, I'm just going to set check=False here. We can improve the interface separately some other time. --js