From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3441FC433ED for ; Thu, 6 May 2021 09:37:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A5616112D for ; Thu, 6 May 2021 09:37:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A5616112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leaRI-0004vv-2b for qemu-devel@archiver.kernel.org; Thu, 06 May 2021 05:37:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leaOQ-0002iz-IQ for qemu-devel@nongnu.org; Thu, 06 May 2021 05:34:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leaON-0000zz-QS for qemu-devel@nongnu.org; Thu, 06 May 2021 05:34:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620293638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oRKi27C6T6C3dvBgN9z/QwKBJ5K86kgfqh9Ls/t1//4=; b=MrvDguT7nH3cEICyUoDmm5gXt3JgAhmO4P/GYPof9lmoEclJC2zFX7aR2WPy0Y85XvcxgY 05q1Ct+8g7uRj6IDoMSiPlvQaPpOk9qzjb7XJUR4mrJTy3sMrgtKIJPgfyWmYrDfl0juLM kFFaGe44uLuH7UCi3SQEW6nZwHFU9lM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-dbUtZh_MO4GPpnzuu3NN1A-1; Thu, 06 May 2021 05:33:56 -0400 X-MC-Unique: dbUtZh_MO4GPpnzuu3NN1A-1 Received: by mail-wm1-f71.google.com with SMTP id d199-20020a1c1dd00000b02901492c14476eso1140399wmd.2 for ; Thu, 06 May 2021 02:33:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oRKi27C6T6C3dvBgN9z/QwKBJ5K86kgfqh9Ls/t1//4=; b=PkrZpm5OE6NRf6GTyHsjwMoOD6XBzCIKVN+tlvhOeERTnk7g3mAGCPLVJ3JMTjPxQF ZJMx16MQyehJK8Nfx5qOIIzq3HEw9FBFVkxjAeuopwR+faXePfKGP/RvLFdiqOb19B20 6FFIHVrA7wFXFKfP5FpCTWmXEwpYCC6Ov160BxqBk0fzt0WuvlYNbw0SZhm0969MKGpF jE0Bu14X4zjWvFfxPCKS7PRWgi8uVIkxDCuQo12fNgpOYSNl1ARGBklCkf/pNc3T4T+9 Tiw1BEA8qu6t5tEnbmnBhdVJFwOqgHBFX8qu1G0GQjg0+GiUK2tuw1HPvuVIUgIiTUmX Ks+A== X-Gm-Message-State: AOAM533kN7q5Bhcn+tW1HB4SqFeN58lImc6xaa0iUkxGqxI1Th8RXzft uaFn8DDF7bE6hgE4SNQ08T852r5P11Q83+xdyWBxi3XMUgrbjOgx1VerkDSejc2Z1okNky/EF0t mTYZXcjz8OhAz8vk= X-Received: by 2002:a05:600c:4a19:: with SMTP id c25mr2981874wmp.94.1620293633781; Thu, 06 May 2021 02:33:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuWfrQ+fOfwpgM2t0qragMs/FeC0arD622du0rtCU3roWKhhusKwEBGF6n2+d92MFiSoWm4g== X-Received: by 2002:a05:600c:4a19:: with SMTP id c25mr2981845wmp.94.1620293633575; Thu, 06 May 2021 02:33:53 -0700 (PDT) Received: from [192.168.1.19] (astrasbourg-652-1-219-60.w90-40.abo.wanadoo.fr. [90.40.114.60]) by smtp.gmail.com with ESMTPSA id 3sm2514838wms.30.2021.05.06.02.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 May 2021 02:33:53 -0700 (PDT) Subject: Re: [PATCH v26 00/20] i386 cleanup PART 2 From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Claudio Fontana , Eduardo Habkost References: <20210301085450.1732-1-cfontana@suse.de> <875z21aghn.fsf@linaro.org> <50c3c1e6-cc62-ee50-874b-72615d7bfac7@suse.de> <87o8dpo4ww.fsf@linaro.org> <03b6b51e-71d7-a2c9-4d3d-db1ac77a1484@redhat.com> <20210505193141.4tb6k5cupbovctbs@habkost.net> Message-ID: <19a1ed59-af39-3c20-2156-6bf4b3026973@redhat.com> Date: Thu, 6 May 2021 11:33:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.693, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Richard Henderson , qemu-devel@nongnu.org, Markus Armbruster , Roman Bolshakov , Igor Mammedov , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/6/21 11:10 AM, Philippe Mathieu-Daudé wrote: > On 5/6/21 9:55 AM, Claudio Fontana wrote: >> On 5/5/21 9:31 PM, Eduardo Habkost wrote: >>> On Wed, May 05, 2021 at 02:15:29PM +0200, Philippe Mathieu-Daudé wrote: >>>> On 5/5/21 12:04 PM, Alex Bennée wrote: >>>>> Claudio Fontana writes: >>>>>> On 3/8/21 3:02 PM, Alex Bennée wrote: >>>>>>> Claudio Fontana writes: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> anything else for me to do here? >>>>>>> >>>>>>> It looks to me that this series is looking pretty good. Every patch has >>>>>>> at least one review so I think it's just waiting on the maintainers to >>>>>>> pick it up. >>>>>>> >>>>>>> Paolo/Richard - are you intending to take the series as is or are you >>>>>>> waiting for something else? I'd like to see the patch delta reduced for >>>>>>> the ARM cleanup work which is still ongoing. >>>>>> >>>>>> I am a bit at a loss here, as this has been reviewed for a while, but nothing is happening. >>>>>> Rebasing is starting to become more and more draining; >>>>> >>>>> This is still the latest re-factor right? >>>>> >>>>> Subject: [PATCH v28 00/23] i386 cleanup PART 2 >>>>> Date: Mon, 22 Mar 2021 14:27:36 +0100 >>>>> Message-Id: <20210322132800.7470-1-cfontana@suse.de> >>>>> >>>>>> I am seeing some changes from Phil that redo some of the patches here (like target arch user), >>>>>> maybe you would like to drive this? >>>>> >>>>> AIUI his changes where to get qtest passing. >>>> >>>> I hadn't read Claudio's mail, I think he's mentioning commit 46369b50ee3 >>>> >>>> meson: Introduce meson_user_arch source set for arch-specific user-mode >>>> >>>> Similarly to the 'target_softmmu_arch' source set which allows >>>> to restrict target-specific sources to system emulation, add >>>> the equivalent 'target_user_arch' set for user emulation. >>>> >>>> The patch only contains 6 lines in 2 hunks, if it introduced a conflict >>>> it should be trivial to resolve (I wasn't expecting it to conflict with >>>> your work when I merged it TBH). > >> I'd suggest to move the discussions about the ARM series to the arm series thread. >> >> I am concerned here about the groundwork and x86 part. > > OK sorry, I was explaining the IRC chat. > > Is there any issue rebasing the groundwork on top of commit 46369b50ee3? > > Maybe my qtest/accel series is irrelevant to your x86 part, TBH I don't > remember. So far I could rebase this series on top of commit 229a834518b (Mon Mar 8 15:45:48 2021). First trivial conflict with 2cc1a90166b ("Remove deprecated target tilegx"), removing target/tilegx/meson.build resolves it. Then apparently commit b8184135835 ("target/i386: allow modifying TCG phys-addr-bits") which is not trivial (to me). Finally "meson: add target_user_arch" indeed clashes with commit 46369b50ee3 ("meson: Introduce meson_user_arch source set for arch-specific user-mode"). I am sorry I didn't notice your patch, but am glad we both sent a similar patch :) Mine allows optional sourceset, so you can simplify your patch, only keeping the x86 part: -- >8 -- diff --git a/target/i386/meson.build b/target/i386/meson.build index fd24479590..cac26a4581 100644 --- a/target/i386/meson.build +++ b/target/i386/meson.build @@ -19,6 +19,7 @@ i386_softmmu_ss.add(files( 'machine.c', 'monitor.c', )) +i386_user_ss = ss.source_set() subdir('kvm') subdir('hax') @@ -28,3 +29,4 @@ subdir('tcg') target_arch += {'i386': i386_ss} target_softmmu_arch += {'i386': i386_softmmu_ss} +target_user_arch += {'i386': i386_user_ss} --- Regards, Phil.