From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC9F7C433F5 for ; Fri, 24 Sep 2021 08:44:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BB2360F41 for ; Fri, 24 Sep 2021 08:44:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4BB2360F41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTgoM-0001BG-Ai for qemu-devel@archiver.kernel.org; Fri, 24 Sep 2021 04:44:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTgnN-0000F5-Ks; Fri, 24 Sep 2021 04:43:02 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:35481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTgnI-000057-Ug; Fri, 24 Sep 2021 04:43:01 -0400 Received: by mail-wr1-x433.google.com with SMTP id i23so25086876wrb.2; Fri, 24 Sep 2021 01:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hNgvGtgIqdvbtXHfdCwXn0B9qOlKwBs1ikr7OYI7/j8=; b=U4DeSyXsfU0zsMkVquf2RDS8mpOSJJPuasEZEABKEAogesh3c+9f9UvxWMZw4X6mYy zz4VY4bpqot2V8wyKnt0cbpirvnmWcpGMfQLIOnNv7fZAR+0v7Tf8SWPjOyh3Nvfx3XM mCVt7y7xZubavdj1G3D8ZBLQXRgKADxObqQnVJMua+h4bJNBH6T67MzCXG1okSROtVHf DaG4w2WTXufNvjShUcxfg/kddLOHJogZ4dGOEBM/DRSCsOKVf0inKSiMqPVZhji3Kt6j 8NXjzKODEdqQiveo+YaMGI6dYeZ8q1VBM/x6XOGkyoBka3EnClpyUfxMSplUIqJqd+b3 80PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hNgvGtgIqdvbtXHfdCwXn0B9qOlKwBs1ikr7OYI7/j8=; b=FxPHG1wWHRTZss7ojJzze2WfRd6uGKddWauAlU5kOVxlwPr4FNFfZ/pSCHpfEq6Iyr B6nfjTF0AtI7L7DlHQMfFpPu+2FUTa0ILNGMWL0+x2alNqNrjf104reHEFo6H/0Vydfn /y3AU3OsC/1WwTR+OAj/0Wlx/Q7gKOsCRtNNNHOj4x9TpIBmbtdQu1WX87Ea5pqifI1N 4fre2aEyvzZKfm/+snZkVjgE8gaRzMJmoK8ESm+bD2gD7ALwNMgadWNcC4kIqncvfUwg lOqARx5XW9/qomQ7jDOKQhW1r3WR33wSteGXQ5J4mlCvuJyLWKh8R4IdkLuOgkVFM7CS 1NvQ== X-Gm-Message-State: AOAM531BA6JL6OD28k6aF8SOFV2BkaittBhf5s60tYdYEhdnGjqVaAw+ nzA0vPq6UzqPFB5Sa2MfciM= X-Google-Smtp-Source: ABdhPJy6/bSJQxYjDiQbYMnlEyMKzSC3nQfAXJ/rFaqz1z1DXLnhaGkeJREf7FoThNL1JZh7IX8X6Q== X-Received: by 2002:adf:f683:: with SMTP id v3mr10211105wrp.423.1632472974963; Fri, 24 Sep 2021 01:42:54 -0700 (PDT) Received: from [192.168.1.36] (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id b204sm11130922wmb.3.2021.09.24.01.42.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Sep 2021 01:42:54 -0700 (PDT) Message-ID: <1a0d6240-6654-0cf7-01ce-ef3ebf497a5c@amsat.org> Date: Fri, 24 Sep 2021 10:42:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] hw/misc: Add an iBT device model Content-Language: en-US To: Titus Rwantare , clg@kaod.org, "andrew@aj.id.au" References: From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hao Wu , qemu-arm@nongnu.org, QEMU Developers , Corey Minyard Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/24/21 01:48, Titus Rwantare wrote: > Hello all, > > I'd like some clarification on how the following code transfers irqs > back and forth: > >> b/hw/arm/aspeed_soc.c >> + /* iBT */ >> + if (!sysbus_realize(SYS_BUS_DEVICE(&s->ibt), errp)) { >> + return; >> + } >> + memory_region_add_subregion(&s->lpc.iomem, >> + sc->memmap[ASPEED_DEV_IBT] - sc->memmap[ASPEED_DEV_LPC], >> + &s->ibt.iomem); >> + sysbus_connect_irq(SYS_BUS_DEVICE(&s->lpc), 1 + aspeed_lpc_ibt, Code smell indeed, likely: sysbus_connect_irq(SYS_BUS_DEVICE(&s->ibt), 1 + aspeed_lpc_ibt, >> + qdev_get_gpio_in(DEVICE(&s->lpc), aspeed_lpc_ibt)); >> } > > and > >> hw/misc/aspeed_ibt.c >> +static void aspeed_ibt_realize(DeviceState *dev, Error **errp) >> +{ >> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); >> + AspeedIBTState *ibt = ASPEED_IBT(dev); > ... >> + >> + sysbus_init_irq(sbd, &ibt->irq); > > I ask because the code in aspeed_soc.c seems to connect to the > lpc->subdevice_irqs[aspeed_lpc_ibt], initialised on > hw/misc/aspeed_lpc.c:408. > I noticed that bmc firmware running in qemu was checking the BT_CTRL > register less frequently than I'd like while editing this patch to use > the IPMIInterface. > > Thanks, > Titus >