From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Max Reitz <mreitz@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH for-5.0 v4 2/5] block: Use bdrv_qapi_perm_to_blk_perm()
Date: Fri, 8 Nov 2019 14:11:32 +0000 [thread overview]
Message-ID: <1dcdf6c3-a378-dd87-aa4d-840cfe2cd4ef@virtuozzo.com> (raw)
In-Reply-To: <20191108123455.39445-3-mreitz@redhat.com>
08.11.2019 15:34, Max Reitz wrote:
> We can save some LoC in xdbg_graph_add_edge() by using
> bdrv_qapi_perm_to_blk_perm().
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block.c | 29 ++++++++---------------------
> 1 file changed, 8 insertions(+), 21 deletions(-)
>
> diff --git a/block.c b/block.c
> index 066433f3e2..ae279ff21f 100644
> --- a/block.c
> +++ b/block.c
> @@ -4870,36 +4870,23 @@ static void xdbg_graph_add_node(XDbgBlockGraphConstructor *gr, void *node,
> static void xdbg_graph_add_edge(XDbgBlockGraphConstructor *gr, void *parent,
> const BdrvChild *child)
> {
> - typedef struct {
> - unsigned int flag;
> - BlockPermission num;
> - } PermissionMap;
> -
> - static const PermissionMap permissions[] = {
> - { BLK_PERM_CONSISTENT_READ, BLOCK_PERMISSION_CONSISTENT_READ },
> - { BLK_PERM_WRITE, BLOCK_PERMISSION_WRITE },
> - { BLK_PERM_WRITE_UNCHANGED, BLOCK_PERMISSION_WRITE_UNCHANGED },
> - { BLK_PERM_RESIZE, BLOCK_PERMISSION_RESIZE },
> - { BLK_PERM_GRAPH_MOD, BLOCK_PERMISSION_GRAPH_MOD },
> - { 0, 0 }
> - };
> - const PermissionMap *p;
> + BlockPermission qapi_perm;
> XDbgBlockGraphEdge *edge;
>
> - QEMU_BUILD_BUG_ON(1UL << (ARRAY_SIZE(permissions) - 1) != BLK_PERM_ALL + 1);
> -
> edge = g_new0(XDbgBlockGraphEdge, 1);
>
> edge->parent = xdbg_graph_node_num(gr, parent);
> edge->child = xdbg_graph_node_num(gr, child->bs);
> edge->name = g_strdup(child->name);
>
> - for (p = permissions; p->flag; p++) {
> - if (p->flag & child->perm) {
> - QAPI_LIST_ADD(edge->perm, p->num);
> + for (qapi_perm = 0; qapi_perm < BLOCK_PERMISSION__MAX; qapi_perm++) {
> + uint64_t flag = bdrv_qapi_perm_to_blk_perm(qapi_perm);
> +
> + if (flag & child->perm) {
> + QAPI_LIST_ADD(edge->perm, qapi_perm);
> }
> - if (p->flag & child->shared_perm) {
> - QAPI_LIST_ADD(edge->shared_perm, p->num);
> + if (flag & child->shared_perm) {
> + QAPI_LIST_ADD(edge->shared_perm, qapi_perm);
> }
> }
>
>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2019-11-08 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 12:34 [PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete Max Reitz
2019-11-08 12:34 ` [PATCH for-5.0 v4 1/5] block: Add bdrv_qapi_perm_to_blk_perm() Max Reitz
2019-11-08 14:05 ` Vladimir Sementsov-Ogievskiy
2019-11-08 12:34 ` [PATCH for-5.0 v4 2/5] block: Use bdrv_qapi_perm_to_blk_perm() Max Reitz
2019-11-08 14:11 ` Vladimir Sementsov-Ogievskiy [this message]
2019-11-08 12:34 ` [PATCH for-5.0 v4 3/5] blkdebug: Allow taking/unsharing permissions Max Reitz
2019-11-08 15:19 ` Vladimir Sementsov-Ogievskiy
2019-11-08 12:34 ` [PATCH for-5.0 v4 4/5] iotests: Add @error to wait_until_completed Max Reitz
2019-11-08 12:34 ` [PATCH for-5.0 v4 5/5] iotests: Add test for failing mirror complete Max Reitz
2019-11-26 8:27 ` [PATCH for-5.0 v4 0/5] iotests: Test " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dcdf6c3-a378-dd87-aa4d-840cfe2cd4ef@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).