qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] target/xtensa: linux-user: add call0 ABI support
Date: Fri, 6 Sep 2019 19:01:33 +0200	[thread overview]
Message-ID: <1ed5286f-fb3a-30b7-d8d1-bdec99f5a792@vivier.eu> (raw)
In-Reply-To: <CAMo8BfK7vsOU1w1HceWGwJS8XF2D+KQmcqgOu0EvaWE6FLFewQ@mail.gmail.com>

Le 06/09/2019 à 18:55, Max Filippov a écrit :
> On Fri, Sep 6, 2019 at 2:33 AM Laurent Vivier <laurent@vivier.eu> wrote:
>> Le 26/08/2019 à 21:58, Max Filippov a écrit :
>>> +#if defined(TARGET_XTENSA)
>>> +    if (getenv("QEMU_XTENSA_ABI_CALL0")) {
>>> +        xtensa_set_abi_call0();
>>> +    }
>>
>> Not needed, this is done by parse_args() that checks
>> getenv(arginfo->env) and calls arginfo->handle_opt()
>> (handle_arg_abi_call0()).
> 
> Thank you, I'll fix that. I got confused by the similar handling of
> QEMU_STRACE, I'll post a cleanup that removes that as well.

Good point.

It seems getenv("QEMU_STRACE") and getenv("QEMU_RAND_SEED") could be
removed.

Thanks,
Laurent



      reply	other threads:[~2019-09-06 17:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 19:58 [Qemu-devel] [PATCH v3] target/xtensa: linux-user: add call0 ABI support Max Filippov
2019-09-05 20:50 ` Max Filippov
2019-09-06  9:33 ` Laurent Vivier
2019-09-06 16:55   ` Max Filippov
2019-09-06 17:01     ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ed5286f-fb3a-30b7-d8d1-bdec99f5a792@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=jcmvbkbc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).