From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FA7C48BD1 for ; Fri, 11 Jun 2021 17:23:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 807EE613CF for ; Fri, 11 Jun 2021 17:23:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 807EE613CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrksi-0006EK-FM for qemu-devel@archiver.kernel.org; Fri, 11 Jun 2021 13:23:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrkr5-0004xP-2K for qemu-devel@nongnu.org; Fri, 11 Jun 2021 13:22:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrkr2-0004t0-Vy for qemu-devel@nongnu.org; Fri, 11 Jun 2021 13:22:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623432119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jbjD2WpJXHAJoCZeF8PVC6xBvK5IpdAGDxP1XByrgEE=; b=DY7Bf+O5kbcgp04ep1UfHmUXccZZP8ULcacjNG2CEGnZyZmaNtRu0Tt10snKRHnDnnu5Xo BbzoPwQ4q4jeruXRbiKauz0pjCwIQ+YGu37HMErebscIfX8wzd5CsUplt+UarJkrIp0Jej e0PNAcwjNhvZgf+DeZ5SKWJr3V3SsRM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-603-mvdv7AnzPFuykYGLgptUYQ-1; Fri, 11 Jun 2021 13:21:58 -0400 X-MC-Unique: mvdv7AnzPFuykYGLgptUYQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F4828015F5; Fri, 11 Jun 2021 17:21:57 +0000 (UTC) Received: from [10.10.116.110] (ovpn-116-110.rdu2.redhat.com [10.10.116.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB07A6064B; Fri, 11 Jun 2021 17:21:56 +0000 (UTC) Subject: Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections To: Markus Armbruster References: <20210519191718.3950330-1-jsnow@redhat.com> <20210519191718.3950330-3-jsnow@redhat.com> <87y2c94gbp.fsf@dusky.pond.sub.org> <542e94f4-be9c-da6a-8307-1a36c8c6c7c4@redhat.com> <87v97cr6np.fsf@dusky.pond.sub.org> <87eed8ihwg.fsf@dusky.pond.sub.org> From: John Snow Message-ID: <1f035a8e-b96e-bd8b-e11c-3eaad233f54e@redhat.com> Date: Fri, 11 Jun 2021 13:21:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87eed8ihwg.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Cleber Rosa , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/11/21 10:40 AM, Markus Armbruster wrote: > John Snow writes: > >> On 5/21/21 1:35 AM, Markus Armbruster wrote: >>> Does not fire for qga/qapi-schema.json. Can you help? >> >> Odd. >> >> I did: >> >> if self._section: >> ... >> else: >> raise QAPIWhicheverErrorItWas(...) >> >> and then did a full build and found it to fail on QGA stuff. You may >> need --enable-docs to make it happen. >> >> It later failed on test cases, too. > > PEBKAC: I tested with a --disable-docs tree. Disabled, because the > conversion to reST restored the "touch anything, rebuild everything" for > docs, which slows me down too much when I mess with the schema. > > This snippet triggers the error: > > ## > # @GuestExec: > # @pid: pid of child process in guest OS > # > # Since: 2.5 > ## > { 'struct': 'GuestExec', > 'data': { 'pid': 'int'} } > > This one doesn't: > > ## > # @GuestExec: > # > # @pid: pid of child process in guest OS > # > # Since: 2.5 > ## > { 'struct': 'GuestExec', > 'data': { 'pid': 'int'} } > > The code dealing with sections is pretty impenetrable. > Yeah, that's what I thought too. I might need (or want?) to touch this soon to do the cross-reference Sphinx stuff, so I figured I'd be coming back here "soon". I could make a gitlab issue for me to track to remind myself to come back to it if you think that's acceptable. --js