From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk,
tony.nguyen@bt.com
Subject: Re: [Qemu-devel] [PATCH 2/3] cputlb: Replace switches in load/store_helper with callback
Date: Wed, 11 Sep 2019 09:20:15 -0400 [thread overview]
Message-ID: <1f4aac93-c0ee-0152-4186-c59f9f1191fe@linaro.org> (raw)
In-Reply-To: <500ed763-5c50-0be5-993d-9b8b1b68b932@redhat.com>
On 9/11/19 9:07 AM, Philippe Mathieu-Daudé wrote:
>> {
>> return load_helper(env, addr, oi, retaddr, MO_LEUW, false,
>> - full_le_lduw_mmu);
>> + full_le_lduw_mmu, direct_lduw_le);
>
> Why not cast lduw_be_p? (except for direct_ldub).
>
> return load_helper(env, addr, oi, retaddr, MO_LEUW, false,
> full_le_lduw_mmu, (DirectLoadHelper)lduw_be_p);
>
> Useful to set breakpoint while debugging?
Because the types in the function signature are different,
and such a cast will cause misbehavior.
r~
next prev parent reply other threads:[~2019-09-11 13:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 1:43 [Qemu-devel] [PATCH 0/3] cputlb: Adjust tlb bswap implementation Richard Henderson
2019-09-11 1:43 ` [Qemu-devel] [PATCH 1/3] cputlb: Disable __always_inline__ without optimization Richard Henderson
2019-09-11 8:34 ` Peter Maydell
2019-09-11 1:43 ` [Qemu-devel] [PATCH 2/3] cputlb: Replace switches in load/store_helper with callback Richard Henderson
2019-09-11 10:55 ` Tony Nguyen
2019-09-11 13:22 ` Richard Henderson
2019-09-11 15:17 ` Tony Nguyen
2019-09-11 13:07 ` Philippe Mathieu-Daudé
2019-09-11 13:20 ` Richard Henderson [this message]
2019-09-11 1:43 ` [Qemu-devel] [PATCH 3/3] cputlb: Introduce TLB_BSWAP Richard Henderson
2019-09-11 14:56 ` Tony Nguyen
2019-09-12 19:07 ` Richard Henderson
2019-09-11 3:46 ` [Qemu-devel] [PATCH 0/3] cputlb: Adjust tlb bswap implementation no-reply
2019-09-11 9:55 ` no-reply
2019-09-11 13:07 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4aac93-c0ee-0152-4186-c59f9f1191fe@linaro.org \
--to=richard.henderson@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tony.nguyen@bt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).