From: Amos Kong <akong@redhat.com>
To: Amos Kong <1253563@bugs.launchpad.net>
Cc: Amit Shah <amit.shah@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, aliguori@amazon.com
Subject: Re: [Qemu-devel] [Bug 1253563] [NEW] bad performance with rng-egd backend
Date: Tue, 26 Nov 2013 23:57:30 +0800 [thread overview]
Message-ID: <20131126155730.GA28334@amosk.info> (raw)
In-Reply-To: <20131121092412.27241.16050.malonedeb@gac.canonical.com>
On Thu, Nov 21, 2013 at 09:24:11AM -0000, Amos Kong wrote:
> Public bug reported:
>
>
> 1. create listen socket
> # cat /dev/random | nc -l localhost 1024
>
> 2. start vm with rng-egd backend
>
> ./x86_64-softmmu/qemu-system-x86_64 --enable-kvm -mon chardev=qmp,mode=control,pretty=on -chardev socket,id=qmp,host=localhost,port=1234,server,nowait -m 2000 -device virtio-net-pci,netdev=h1,id=vnet0 -netdev tap,id=h1 -vnc :0 -drive file=/images/RHEL-64-virtio.qcow2 \
> -chardev socket,host=localhost,port=1024,id=chr0 \
> -object rng-egd,chardev=chr0,id=rng0 \
> -device virtio-rng-pci,rng=rng0,max-bytes=1024000,period=1000
>
> (guest) # dd if=/dev/hwrng of=/dev/null
>
> note: cancelling dd process by Ctrl+c, it will return the read speed.
>
> Problem: the speed is around 1k/s
>
> ===================
>
> If I use rng-random backend (filename=/dev/random), the speed is about
> 350k/s).
>
> It seems that when the request entry is added to the list, we don't read the data from queue list immediately.
> The chr_read() is delayed, the virtio_notify() is delayed. the next request will also be delayed. It effects the speed.
Currently we have a request queue to cache un-processed request,
but new request_entropy is only comming when last request is processed
(chr dev data is filled to request->data, copied to VQ, and notify
virtio.
So the queue always has 0 or 1 items. The request process is designed
to sync, but it doesn't work.
Does this limitation come from virtio-rng driver in guest?
> I tried to change rng_egd_chr_can_read() always returns 1, the speed is
> improved to (about 400k/s)
>
> Problem: we can't poll the content in time currently
> Any thoughts?
>
> Thanks, Amos
next prev parent reply other threads:[~2013-11-26 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 9:24 [Qemu-devel] [Bug 1253563] [NEW] bad performance with rng-egd backend Amos Kong
2013-11-21 11:01 ` Launchpad Bug Tracker
2013-11-26 15:57 ` Amos Kong [this message]
2020-08-07 10:05 ` [Bug 1253563] " Thomas Huth
2020-08-19 8:07 ` Amos Jianjun Kong
2020-10-19 4:17 ` Launchpad Bug Tracker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126155730.GA28334@amosk.info \
--to=akong@redhat.com \
--cc=1253563@bugs.launchpad.net \
--cc=aliguori@amazon.com \
--cc=amit.shah@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).