From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 00/22] Convert migration to QIOChannel & support TLS
Date: Tue, 12 Jan 2016 11:59:36 +0000 [thread overview]
Message-ID: <20160112115936.GB17626@redhat.com> (raw)
In-Reply-To: <1452599056-27357-1-git-send-email-berrange@redhat.com>
BTW, also available at
https://github.com/berrange/qemu/tree/io-channel-migration-1
On Tue, Jan 12, 2016 at 11:43:54AM +0000, Daniel P. Berrange wrote:
> This is a formal posting of patches that were previously
> previewed at:
>
> FYI: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html
>
> The primary goal of this series of patches is to support TLS on the
> migration data channel. The bulk of the work in this series though,
> is converting the various QEMUFile implementations to be baed on the
> new QIOChannel framework.
>
> At the end of this current series there is just one remaining impl
> of QEMUFileOps that is not based on QIOChannel - the one in savevm.c
> that is using BlockDriverState. It would be possible to create a
> QIOChannel wrapper around BlockDriverState too, at which point all
> QEMUFile impls would be QIOChannel based. This would then let us
> cut out the QEMUFileOps driver callbacks entirely and thus simply
> code even more. This patch series is already too large, so I left
> that for now.
>
> The first 6 patchs are some basic clean ups to QEMUFile code
>
> The 7th patch introduces the QIOChannel based QEMUFile impl
>
> Patches 8-14 convert the various migration protocols to use
> the QIOChannel based QEMUFile impl.
>
> Patches 15-18 remove the now unused QEMUFile impls that do
> not use QIOChanel
>
> Patches 19, 21 and 22 does some more cleanup
>
> Patch 20 achieves the original stated primary goal of adding
> TLS encryption to the TCP migration backend.
>
> Overall we have a net win of deleting 500 lines of code,
> despite adding more features, which is always nice.
>
> I testing unix, tcp, exec migrations. I don't have the ability
> to test RDMA migration, and that's the patch I'm also least
> confident about code quality of, so would appreciated some
> independant testing of that one in particular.
>
>
> Daniel P. Berrange (22):
> s390: use FILE instead of QEMUFile for creating text file
> migration: remove use of qemu_bufopen from vmstate tests
> migration: ensure qemu_fflush() always writes full data amount
> migration: split migration hooks out of QEMUFileOps
> migration: introduce set_blocking function in QEMUFileOps
> migration: force QEMUFile to blocking mode for outgoing migration
> migration: introduce a new QEMUFile impl based on QIOChannel
> migration: convert post-copy to use QIOChannelBuffer
> migration: convert unix socket protocol to use QIOChannel
> migration: convert tcp socket protocol to use QIOChannel
> migration: convert fd socket protocol to use QIOChannel
> migration: convert exec socket protocol to use QIOChannel
> migration: convert RDMA to use QIOChannel interface
> migration: convert savevm to use QIOChannel for writing to files
> migration: delete QEMUFile buffer implementation
> migration: delete QEMUSizedBuffer struct
> migration: delete QEMUFile sockets implementation
> migration: delete QEMUFile stdio implementation
> migration: move definition of struct QEMUFile back into qemu-file.c
> migration: support TLS encryption with TCP migration backend
> migration: remove support for non-iovec based write handlers
> migration: remove qemu_get_fd method from QEMUFile
>
> docs/migration.txt | 4 +-
> hw/s390x/s390-skeys.c | 19 +-
> include/migration/qemu-file.h | 57 ++---
> include/qemu/typedefs.h | 1 -
> include/sysemu/sysemu.h | 2 +-
> migration/Makefile.objs | 6 +-
> migration/exec.c | 48 +++--
> migration/fd.c | 57 +++--
> migration/migration.c | 24 +--
> migration/qemu-file-buf.c | 463 -----------------------------------------
> migration/qemu-file-channel.c | 201 ++++++++++++++++++
> migration/qemu-file-internal.h | 53 -----
> migration/qemu-file-stdio.c | 195 -----------------
> migration/qemu-file-unix.c | 324 ----------------------------
> migration/qemu-file.c | 110 +++++-----
> migration/rdma.c | 256 ++++++++++++++---------
> migration/savevm.c | 57 ++---
> migration/tcp.c | 372 +++++++++++++++++++++++++++++----
> migration/unix.c | 103 +++++----
> qemu-options.hx | 7 +-
> tests/Makefile | 6 +-
> tests/test-vmstate.c | 55 ++---
> 22 files changed, 975 insertions(+), 1445 deletions(-)
> delete mode 100644 migration/qemu-file-buf.c
> create mode 100644 migration/qemu-file-channel.c
> delete mode 100644 migration/qemu-file-internal.h
> delete mode 100644 migration/qemu-file-stdio.c
> delete mode 100644 migration/qemu-file-unix.c
>
> --
> 2.5.0
>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-01-12 11:59 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 11:43 [Qemu-devel] [PATCH v1 00/22] Convert migration to QIOChannel & support TLS Daniel P. Berrange
2016-01-12 11:43 ` [Qemu-devel] [PATCH v1 01/22] s390: use FILE instead of QEMUFile for creating text file Daniel P. Berrange
2016-01-12 11:58 ` Cornelia Huck
2016-01-12 12:01 ` Daniel P. Berrange
2016-01-12 12:05 ` Cornelia Huck
2016-02-12 17:19 ` Dr. David Alan Gilbert
2016-01-12 11:43 ` [Qemu-devel] [PATCH v1 02/22] migration: remove use of qemu_bufopen from vmstate tests Daniel P. Berrange
2016-01-28 17:45 ` Dr. David Alan Gilbert
2016-01-12 11:43 ` [Qemu-devel] [PATCH v1 03/22] migration: ensure qemu_fflush() always writes full data amount Daniel P. Berrange
2016-01-28 17:53 ` Dr. David Alan Gilbert
2016-02-03 13:31 ` Daniel P. Berrange
2016-01-12 11:43 ` [Qemu-devel] [PATCH v1 04/22] migration: split migration hooks out of QEMUFileOps Daniel P. Berrange
2016-01-28 17:57 ` Dr. David Alan Gilbert
2016-01-12 11:43 ` [Qemu-devel] [PATCH v1 05/22] migration: introduce set_blocking function in QEMUFileOps Daniel P. Berrange
2016-01-28 18:00 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 06/22] migration: force QEMUFile to blocking mode for outgoing migration Daniel P. Berrange
2016-01-28 18:17 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 07/22] migration: introduce a new QEMUFile impl based on QIOChannel Daniel P. Berrange
2016-02-02 17:06 ` Dr. David Alan Gilbert
2016-02-03 13:37 ` Daniel P. Berrange
2016-02-12 17:16 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 08/22] migration: convert post-copy to use QIOChannelBuffer Daniel P. Berrange
2016-01-25 19:38 ` Dr. David Alan Gilbert
2016-01-25 22:15 ` Daniel P. Berrange
2016-01-26 18:59 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 09/22] migration: convert unix socket protocol to use QIOChannel Daniel P. Berrange
2016-02-02 18:02 ` Dr. David Alan Gilbert
2016-02-03 11:25 ` Daniel P. Berrange
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 10/22] migration: convert tcp " Daniel P. Berrange
2016-02-02 18:19 ` Dr. David Alan Gilbert
2016-02-03 10:02 ` Daniel P. Berrange
2016-02-03 10:33 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 11/22] migration: convert fd " Daniel P. Berrange
2016-02-02 18:46 ` Dr. David Alan Gilbert
2016-02-03 10:05 ` Daniel P. Berrange
2016-02-03 10:29 ` Dr. David Alan Gilbert
2016-02-03 10:39 ` Daniel P. Berrange
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 12/22] migration: convert exec " Daniel P. Berrange
2016-02-02 18:53 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 13/22] migration: convert RDMA to use QIOChannel interface Daniel P. Berrange
2016-02-02 20:01 ` Dr. David Alan Gilbert
2016-02-03 11:37 ` Daniel P. Berrange
2016-02-03 13:23 ` Dr. David Alan Gilbert
2016-02-03 13:25 ` Daniel P. Berrange
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 14/22] migration: convert savevm to use QIOChannel for writing to files Daniel P. Berrange
2016-02-03 9:52 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 15/22] migration: delete QEMUFile buffer implementation Daniel P. Berrange
2016-02-03 9:54 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 16/22] migration: delete QEMUSizedBuffer struct Daniel P. Berrange
2016-02-03 9:55 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 17/22] migration: delete QEMUFile sockets implementation Daniel P. Berrange
2016-02-03 9:56 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 18/22] migration: delete QEMUFile stdio implementation Daniel P. Berrange
2016-02-03 9:58 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 19/22] migration: move definition of struct QEMUFile back into qemu-file.c Daniel P. Berrange
2016-02-05 18:32 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 20/22] migration: support TLS encryption with TCP migration backend Daniel P. Berrange
2016-02-12 17:09 ` Dr. David Alan Gilbert
2016-02-12 17:25 ` Daniel P. Berrange
2016-02-15 11:00 ` Daniel P. Berrange
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 21/22] migration: remove support for non-iovec based write handlers Daniel P. Berrange
2016-02-12 15:48 ` Dr. David Alan Gilbert
2016-01-12 11:44 ` [Qemu-devel] [PATCH v1 22/22] migration: remove qemu_get_fd method from QEMUFile Daniel P. Berrange
2016-02-12 15:51 ` Dr. David Alan Gilbert
2016-01-12 11:59 ` Daniel P. Berrange [this message]
2016-01-20 18:01 ` [Qemu-devel] [PATCH v1 00/22] Convert migration to QIOChannel & support TLS Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112115936.GB17626@redhat.com \
--to=berrange@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).