From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIyMF-0001Uw-0q for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:47:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIyMB-0005kO-A8 for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:47:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIyMB-0005k3-0k for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:47:27 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 35EE01A65B9 for ; Tue, 12 Jan 2016 12:47:26 +0000 (UTC) Date: Tue, 12 Jan 2016 12:47:22 +0000 From: "Daniel P. Berrange" Message-ID: <20160112124722.GG17626@redhat.com> References: <1452601779-5790-1-git-send-email-kraxel@redhat.com> <1452601779-5790-4-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1452601779-5790-4-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/7] qapi: switch x-input-send-event from console to device+head Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Markus Armbruster On Tue, Jan 12, 2016 at 01:29:36PM +0100, Gerd Hoffmann wrote: > Use display device qdev id and head number instead of console index to > specify the QemuConsole. This makes things consistent with input > devices (for input routing) and vnc server configuration, which both use > display and head too. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 32 +++++++++++++++++--------------- > qmp-commands.hx | 15 ++++++++------- > ui/input.c | 15 ++++++++++----- > 3 files changed, 35 insertions(+), 27 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|