From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings
Date: Mon, 18 Jan 2016 19:28:43 +0100 [thread overview]
Message-ID: <20160118192843.55ef9d93@bahia.huguette.org> (raw)
In-Reply-To: <569D22F6.5070104@msgid.tls.msk.ru>
On Mon, 18 Jan 2016 20:37:58 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:
> 11.01.2016 20:30, Greg Kurz wrote:
>
> > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64""
> > +virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64
> ...
>
> I'm not sure what's the value of this. It's fine either way, no?
The only value is to drop unneeded stuff... and maybe some consistency
with the traces that don't have these trailing empty strings.
> Do we have a rule for trailing empty strings in coding style? :)
>
Nor we have against parenthesitis, which brings a lot more unneeded
characters into the code :P
More seriously, I posted this because it was discussed earlier this month.
But honestly, I don't care if you don't want to push it. :)
> Thanks,
>
> /mjt
>
Cheers.
--
Greg
next prev parent reply other threads:[~2016-01-18 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 17:30 [Qemu-devel] [PATCH] trace: drop trailing empty strings Greg Kurz
2016-01-15 17:24 ` Eric Blake
2016-01-18 17:37 ` Michael Tokarev
2016-01-18 18:28 ` Greg Kurz [this message]
2016-02-08 15:11 ` Stefan Hajnoczi
2016-02-08 15:39 ` Markus Armbruster
2016-02-09 16:05 ` Stefan Hajnoczi
2016-01-19 7:35 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118192843.55ef9d93@bahia.huguette.org \
--to=gkurz@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).