Re: [Qemu-devel] [PATCH 06/13] cuda: port POWERDOWN command to new framework

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]

On Sat, Jan 23, 2016 at 09:40:03PM +0100, Hervé Poussineau wrote:
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  hw/misc/macio/cuda.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c
> index 9af8e1d..df4797f 100644
> --- a/hw/misc/macio/cuda.c
> +++ b/hw/misc/macio/cuda.c
> @@ -601,10 +601,23 @@ static bool cuda_cmd_set_device_list(CUDAState *s,
>      return true;
>  }
>  
> +static bool cuda_cmd_powerdown(CUDAState *s,
> +                               const uint8_t *in_data, int in_len,
> +                               uint8_t *out_data, int *out_len)
> +{
> +    if (in_len != 0) {
> +        return false;
> +    }
> +
> +    qemu_system_shutdown_request();
> +    return true;
> +}
> +
>  static const CudaCommand handlers[] = {
>      { CUDA_AUTOPOLL, "AUTOPOLL", cuda_cmd_autopoll },
>      { CUDA_SET_AUTO_RATE, "SET_AUTO_RATE",  cuda_cmd_set_autorate },
>      { CUDA_SET_DEVICE_LIST, "SET_DEVICE_LIST", cuda_cmd_set_device_list },
> +    { CUDA_POWERDOWN, "POWERDOWN", cuda_cmd_powerdown },
>  };
>  
>  static void cuda_receive_packet(CUDAState *s,
> @@ -656,10 +669,6 @@ static void cuda_receive_packet(CUDAState *s,
>      case CUDA_SET_POWER_MESSAGES:
>          cuda_send_packet_to_host(s, obuf, 3);
>          return;
> -    case CUDA_POWERDOWN:
> -        cuda_send_packet_to_host(s, obuf, 3);
> -        qemu_system_shutdown_request();
> -        return;
>      case CUDA_RESET_SYSTEM:
>          cuda_send_packet_to_host(s, obuf, 3);
>          qemu_system_reset_request();

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]