From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOn9S-0007VM-DG for qemu-devel@nongnu.org; Thu, 28 Jan 2016 09:02:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOn9M-0002Wk-PY for qemu-devel@nongnu.org; Thu, 28 Jan 2016 09:02:22 -0500 Date: Thu, 28 Jan 2016 12:02:12 -0200 From: Eduardo Habkost Message-ID: <20160128140212.GS3869@thinpad.lan.raisama.net> References: <1453978470-222624-1-git-send-email-imammedo@redhat.com> <1453978688-222752-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453978688-222752-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: agraf@suse.de, mst@redhat.com, ghammer@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, cornelia.huck@de.ibm.com, pbonzini@redhat.com, rth@twiddle.net, david@gibson.dropbear.id.au On Thu, Jan 28, 2016 at 11:58:08AM +0100, Igor Mammedov wrote: > Switch to adding compat properties incrementaly instead of > completly overwriting compat_props per machine type. > That removes data duplication which we have due to nested > [PC|SPAPR]_COMPAT_* macros. > > It also allows to set default device properties from > default foo_machine_options() hook, which will be used > in following patch for putting VMGENID device as > a function if ISA bridge on pc/q35 machines. > > Suggested-by: Eduardo Habkost > Signed-off-by: Igor Mammedov > Very nice. The only suggestion I have is to use the simpler GList type, instead of GArray. Reviewed-by: Eduardo Habkost > compat_props GArray I assume this line was left here by mistake? > --- > hw/core/machine.c | 10 ++++++++++ > hw/ppc/spapr.c | 3 --- > hw/s390x/s390-virtio-ccw.c | 12 ++---------- > include/hw/boards.h | 11 +++++++++-- > include/hw/i386/pc.h | 9 --------- > vl.c | 6 +++++- > 6 files changed, 26 insertions(+), 25 deletions(-) [...] -- Eduardo