From: Igor Mammedov <imammedo@redhat.com>
To: Wei Huang <wei@redhat.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
"zhaoshenglong@huawei.com" <zhaoshenglong@huawei.com>,
Shannon Zhao <shannon.zhao@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse
Date: Mon, 1 Feb 2016 11:17:36 +0100 [thread overview]
Message-ID: <20160201111736.155e82fa@nial.brq.redhat.com> (raw)
In-Reply-To: <56AB818B.1060500@redhat.com>
On Fri, 29 Jan 2016 09:13:15 -0600
Wei Huang <wei@redhat.com> wrote:
> On 01/29/2016 08:50 AM, Peter Maydell wrote:
> > On 29 January 2016 at 14:46, Shannon Zhao <shannon.zhao@linaro.org> wrote:
> >> On 2016/1/29 22:35, Wei Huang wrote:
> >>> On 01/29/2016 04:10 AM, Shannon Zhao wrote:
> >>>> This makes ACPI work well but makes DT not work. The reason is systemd or
> >>>> acpid open /dev/input/event0 failed. So the interrupt could be injected
> >>>> and
> >>>> could see under /proc/interrupts but guest doesn't have any action. I'll
> >>>> investigate why it opens failed later.
> >>>
> >>>
> >>> That is interesting. Could you try it with the following? This reverses
> >>> the order to down-up and worked on ACPI case.
> >>>
> >> Yeah, that's very weird.
> >>
> >>> qemu_set_irq(qdev_get_gpio_in(pl061_dev, 3), 0);
> >>> qemu_set_irq(qdev_get_gpio_in(pl061_dev, 3), 1);
> >>>
> >> I'll try this tomorrow. But even if this works, it's still weird.
> >
> > I wonder if we should be asserting the GPIO pin in the powerdown-request
> > hook and then deasserting it on system reset somewhere...
>
> This is another possibility. We can try to reset the pl061 state by
> hooking up with dc->reset and see what happens.
I think that's what we do on x86.
>
> >
> > thanks
> > -- PMM
> >
>
next prev parent reply other threads:[~2016-02-01 10:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 18:22 [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse Wei Huang
2016-01-29 10:10 ` Shannon Zhao
2016-01-29 14:35 ` Wei Huang
2016-01-29 14:46 ` Shannon Zhao
2016-01-29 14:50 ` Wei Huang
2016-01-29 15:22 ` Shannon Zhao
2016-01-29 14:50 ` Peter Maydell
2016-01-29 15:13 ` Wei Huang
2016-01-29 15:29 ` Peter Maydell
2016-02-01 10:17 ` Igor Mammedov [this message]
2016-02-01 17:24 ` Wei Huang
2016-01-30 8:18 ` Shannon Zhao
2016-02-03 7:15 ` Michael Tokarev
2016-02-03 10:46 ` Peter Maydell
2016-02-03 16:01 ` Wei Huang
2016-02-04 1:44 ` Shannon Zhao
2016-02-04 6:10 ` Wei Huang
2016-02-04 6:51 ` Shannon Zhao
2016-02-09 22:59 ` Wei Huang
2016-02-20 10:53 ` Shannon Zhao
2016-02-24 22:22 ` Wei Huang
2016-02-26 12:31 ` Shannon Zhao
2016-02-26 12:53 ` Peter Maydell
2016-02-26 14:54 ` Shannon Zhao
2016-02-26 15:06 ` Peter Maydell
2016-02-26 15:28 ` Wei Huang
2016-02-26 15:42 ` Peter Maydell
2016-02-27 1:55 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201111736.155e82fa@nial.brq.redhat.com \
--to=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=wei@redhat.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).