From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/16] aio: first part of aio_context_acquire/release pushdown
Date: Tue, 2 Feb 2016 17:26:12 +0000 [thread overview]
Message-ID: <20160202172612.GC32084@stefanha-x1.localdomain> (raw)
In-Reply-To: <1452870739-28484-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3688 bytes --]
On Fri, Jan 15, 2016 at 04:12:03PM +0100, Paolo Bonzini wrote:
> This is the infrastructure part of the aio_context_acquire/release pushdown,
> which in turn is the first step towards a real multiqueue block layer in
> QEMU. The next step is to touch all the drivers and move calls to the
> aio_context_acquire/release functions from aio-*.c to the drivers. This
> will be done in a separate patch series.
>
> While the inserted lines are a lot, more than half of it are in documentation
> and formal models of the code, as well as in the implementation of the new
> "lockcnt" synchronization primitive. The code is also very heavily commented.
>
> The first four patches are new, as the issue they fix was found after posting
> the previous patch. Everything else is more or less the same as before.
>
> Paolo
>
> Paolo Bonzini (16):
> aio: introduce aio_context_in_iothread
> aio: do not really acquire/release the main AIO context
> aio: introduce aio_poll_internal
> aio: only call aio_poll_internal from iothread
> iothread: release AioContext around aio_poll
> qemu-thread: introduce QemuRecMutex
> aio: convert from RFifoLock to QemuRecMutex
> aio: rename bh_lock to list_lock
> qemu-thread: introduce QemuLockCnt
> aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh
> qemu-thread: optimize QemuLockCnt with futexes on Linux
> aio: tweak walking in dispatch phase
> aio-posix: remove walking_handlers, protecting AioHandler list with list_lock
> aio-win32: remove walking_handlers, protecting AioHandler list with list_lock
> aio: document locking
> aio: push aio_context_acquire/release down to dispatching
>
> aio-posix.c | 86 +++++----
> aio-win32.c | 106 ++++++-----
> async.c | 277 +++++++++++++++++++++++----
> block/io.c | 14 +-
> docs/aio_poll_drain.promela | 210 +++++++++++++++++++++
> docs/aio_poll_drain_bug.promela | 158 ++++++++++++++++
> docs/aio_poll_sync_io.promela | 88 +++++++++
> docs/lockcnt.txt | 342 ++++++++++++++++++++++++++++++++++
> docs/multiple-iothreads.txt | 48 ++---
> include/block/aio.h | 69 ++++---
> include/qemu/futex.h | 36 ++++
> include/qemu/rfifolock.h | 54 ------
> include/qemu/thread-posix.h | 6 +
> include/qemu/thread-win32.h | 10 +
> include/qemu/thread.h | 23 +++
> iothread.c | 20 +-
> stubs/iothread-lock.c | 5 +
> tests/.gitignore | 1 -
> tests/Makefile | 2 -
> tests/test-aio.c | 19 +-
> tests/test-rfifolock.c | 91 ---------
> trace-events | 10 +
> util/Makefile.objs | 2 +-
> util/lockcnt.c | 404 ++++++++++++++++++++++++++++++++++++++++
> util/qemu-thread-posix.c | 38 ++--
> util/qemu-thread-win32.c | 25 +++
> util/rfifolock.c | 78 --------
> 27 files changed, 1779 insertions(+), 443 deletions(-)
> create mode 100644 docs/aio_poll_drain.promela
> create mode 100644 docs/aio_poll_drain_bug.promela
> create mode 100644 docs/aio_poll_sync_io.promela
> create mode 100644 docs/lockcnt.txt
> create mode 100644 include/qemu/futex.h
> delete mode 100644 include/qemu/rfifolock.h
> delete mode 100644 tests/test-rfifolock.c
> create mode 100644 util/lockcnt.c
> delete mode 100644 util/rfifolock.c
I sent a mail about outdated documentation. Besides that:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-02-02 17:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 15:12 [Qemu-devel] [PATCH 00/16] aio: first part of aio_context_acquire/release pushdown Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 01/16] aio: introduce aio_context_in_iothread Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 02/16] aio: do not really acquire/release the main AIO context Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 03/16] aio: introduce aio_poll_internal Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 04/16] aio: only call aio_poll_internal from iothread Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll Paolo Bonzini
2016-02-02 14:52 ` Stefan Hajnoczi
2016-02-02 15:01 ` Paolo Bonzini
2016-02-03 9:34 ` Stefan Hajnoczi
2016-02-03 9:52 ` Paolo Bonzini
2016-02-05 17:51 ` Stefan Hajnoczi
2016-02-08 15:34 ` Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 06/16] qemu-thread: introduce QemuRecMutex Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 07/16] aio: convert from RFifoLock to QemuRecMutex Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 08/16] aio: rename bh_lock to list_lock Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 09/16] qemu-thread: introduce QemuLockCnt Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 10/16] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 11/16] qemu-thread: optimize QemuLockCnt with futexes on Linux Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 12/16] aio: tweak walking in dispatch phase Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 13/16] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 14/16] aio-win32: " Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 15/16] aio: document locking Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 16/16] aio: push aio_context_acquire/release down to dispatching Paolo Bonzini
2016-02-02 9:41 ` [Qemu-devel] [PATCH 00/16] aio: first part of aio_context_acquire/release pushdown Paolo Bonzini
2016-02-02 17:26 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202172612.GC32084@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).