From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50349)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1aRi8O-0005fb-Qs
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 10:17:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1aRi8L-0007gh-L1
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 10:17:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1aRi8L-0007gd-Fz
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 10:17:17 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id C4D946113
	for <qemu-devel@nongnu.org>; Fri,  5 Feb 2016 15:17:16 +0000 (UTC)
Date: Fri, 5 Feb 2016 13:17:14 -0200
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20160205151714.GD26447@thinpad.lan.raisama.net>
References: <1454586455-10202-1-git-send-email-imammedo@redhat.com>
	<1454586455-10202-5-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454586455-10202-5-git-send-email-imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/9] pc: acpi: create Processor and Notify
 objects only for valid lapics
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com

On Thu, Feb 04, 2016 at 12:47:31PM +0100, Igor Mammedov wrote:
> do not assume that all lapics in range 0..apic_id_limit
> are valid and do not create Processor and Notify objects
> for not possible lapics.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Any specific reason you split the Processor/Notify changes and
the MADT/lapic entries into patches 5 and 6? Won't guests be
confused if the Processor entries are missing but the lapic
entries are still there?

I wouldn't mind merging patches 4-6 into a single patch, just to
avoid risking unnecessary bisectability issues.

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

-- 
Eduardo