From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRiXg-0000Q7-Hu for qemu-devel@nongnu.org; Fri, 05 Feb 2016 10:43:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRiXb-0006E9-I2 for qemu-devel@nongnu.org; Fri, 05 Feb 2016 10:43:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRiXb-0006Dq-CQ for qemu-devel@nongnu.org; Fri, 05 Feb 2016 10:43:23 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id E795D77356 for ; Fri, 5 Feb 2016 15:43:22 +0000 (UTC) Date: Fri, 5 Feb 2016 16:43:20 +0100 From: Igor Mammedov Message-ID: <20160205164320.686ff6c7@nial.brq.redhat.com> In-Reply-To: <20160205151714.GD26447@thinpad.lan.raisama.net> References: <1454586455-10202-1-git-send-email-imammedo@redhat.com> <1454586455-10202-5-git-send-email-imammedo@redhat.com> <20160205151714.GD26447@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/9] pc: acpi: create Processor and Notify objects only for valid lapics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On Fri, 5 Feb 2016 13:17:14 -0200 Eduardo Habkost wrote: > On Thu, Feb 04, 2016 at 12:47:31PM +0100, Igor Mammedov wrote: > > do not assume that all lapics in range 0..apic_id_limit > > are valid and do not create Processor and Notify objects > > for not possible lapics. > > > > Signed-off-by: Igor Mammedov > > Any specific reason you split the Processor/Notify changes and > the MADT/lapic entries into patches 5 and 6? Won't guests be > confused if the Processor entries are missing but the lapic > entries are still there? Guest shouldn't be confused as MADT is used during while Processor during hotplug. > > I wouldn't mind merging patches 4-6 into a single patch, just to > avoid risking unnecessary bisectability issues. Patches were split to make them smaller and more reviewable but I'm ok with merging them together > > Reviewed-by: Eduardo Habkost >