From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40244)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1aSnTu-0000vh-K1
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:12:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1aSnTt-0002pG-HR
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:12:02 -0500
Date: Mon, 8 Feb 2016 15:11:47 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20160208151147.GC31586@stefanha-x1.localdomain>
References: <20160111173036.24764.59878.stgit@bahia.huguette.org>
	<569D22F6.5070104@msgid.tls.msk.ru>
	<20160118192843.55ef9d93@bahia.huguette.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+"
Content-Disposition: inline
In-Reply-To: <20160118192843.55ef9d93@bahia.huguette.org>
Subject: Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org


--ZwgA9U+XZDXt4+m+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 18, 2016 at 07:28:43PM +0100, Greg Kurz wrote:
> On Mon, 18 Jan 2016 20:37:58 +0300
> Michael Tokarev <mjt@tls.msk.ru> wrote:
>=20
> > 11.01.2016 20:30, Greg Kurz wrote:
> >=20
> > > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "sectio=
n name: %s gpa: %"PRIx64""
> > > +virtio_balloon_handle_output(const char *name, uint64_t gpa) "sectio=
n name: %s gpa: %"PRIx64 =20
> > ...
> >=20
> > I'm not sure what's the value of this.  It's fine either way, no?
>=20
> The only value is to drop unneeded stuff... and maybe some consistency
> with the traces that don't have these trailing empty strings.
>=20
> > Do we have a rule for trailing empty strings in coding style? :)
> >=20
>=20
> Nor we have against parenthesitis, which brings a lot more unneeded
> characters into the code :P

Regarding the history of the quoting limitation, see commit
cf85cf8e972f3ad79f203be4edb7968d6e052293 ("trace: Format strings must
begin/end with double quotes").  It was a limitation of the old
tracetool.sh script.

The modern tracetool.py script handles format strings fine when they do
not end with double-quotes.

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

--ZwgA9U+XZDXt4+m+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJWuLAzAAoJEJykq7OBq3PIzGcH/jPxKtj492e/ezj2hp2dTWYm
I26mELahR/U1WLfT2Vwk0LJsphfDWvQqAmXumPQtMap7iLZr8teCdVtBxgWYaebc
wSlB+PW5lY1/h4iA0ONyL5Wq1gONEc33ktjJ70eZCmQFogkNpJS6xgH/TFweizz6
LVQsKUILN3Xyx/pNuzYXDxkZi1j6lOBjfQlGsPjwieTo8YQExvRZIWPxuYKIaMup
f+nHLiWojzT1B7Oer3YfjcoXFxmVABhyFHKfVnK5XuK1s2vqeY9HK8QdsPpEhyBA
oRIcl9Qp9bGit5uMj66roHOFZM1kbz01e0CbOxtAuGUMiFA38j8LUfRn9DQoV2M=
=p0nL
-----END PGP SIGNATURE-----

--ZwgA9U+XZDXt4+m+--