From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTA9x-0002by-Ug for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:25:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTA9u-00067b-Jt for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:24:57 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:6935 helo=imgpgp01.kl.imgtec.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTA9u-000675-BL for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:24:54 -0500 Date: Tue, 9 Feb 2016 15:24:49 +0000 From: James Hogan Message-ID: <20160209152449.GA3678@jhogan-linux.le.imgtec.org> References: <1455014403-10742-1-git-send-email-rth@twiddle.net> <1455014403-10742-3-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <1455014403-10742-3-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 02/15] tcg-mips: Support 64-bit opcodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, aurelien@aurel32.net --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Richard, Awesome, thanks for looking at these patches again :-) On Tue, Feb 09, 2016 at 09:39:50PM +1100, Richard Henderson wrote: > +#if !use_mips32r6_instructions > + { INDEX_op_muls2_i64, { "r", "r", "rZ", "rZ" } }, > + { INDEX_op_mulu2_i64, { "r", "r", "rZ", "rZ" } }, > +#endif this... > +#define TCG_TARGET_HAS_mulu2_i64 1 > +#define TCG_TARGET_HAS_muls2_i64 1 and this are inconsistent for r6: Missing op definition for mulu2_i64=20 Missing op definition for muls2_i64=20 /work/mips/qemu/main/tcg/tcg.c:1253: tcg fatal error It gets further (to the point of seg faulting - looking into it) with this fixup: diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h index 374d80374021..fa9cd4ab296a 100644 --- a/tcg/mips/tcg-target.h +++ b/tcg/mips/tcg-target.h @@ -145,8 +145,8 @@ extern bool use_mips32r2_instructions; #define TCG_TARGET_HAS_nand_i64 0 #define TCG_TARGET_HAS_add2_i64 0 #define TCG_TARGET_HAS_sub2_i64 0 -#define TCG_TARGET_HAS_mulu2_i64 1 -#define TCG_TARGET_HAS_muls2_i64 1 +#define TCG_TARGET_HAS_mulu2_i64 (!use_mips32r6_instructions) +#define TCG_TARGET_HAS_muls2_i64 (!use_mips32r6_instructions) #define TCG_TARGET_HAS_muluh_i64 1 #define TCG_TARGET_HAS_mulsh_i64 1 #define TCG_TARGET_HAS_ext32s_i64 1 Cheers James --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWugTBAAoJEGwLaZPeOHZ6dgcQAIbNNgx2N9Ly1S3hXuPu5O6/ +aGZWWtJulrKdxPqeh4sgNeW6Iq6ZO2Z2c3BE9XR5hmCPQP5kiEfgcLiQ157h+En jzDC7vSI0E7ryQ18zMN69vyhcbZU58dT4/hJHl5sEgUv+V5ia5+9XWH/glXXO+Yd xQedr7oBzOFM3zQjwgUybdNRJQ8W/Ucb2lvbTLZupF7+tqYLznYhUAIXHxlEe7id hMJj2ZOZkerinJ5cmcqH94UJVwL0Y7AWoJYRIR8GmUayzvXots569FnxwfrbpmvZ kYkHQiK5zgDgZd6b2mfV5qCf3lB9RWqiZNVBQmmsRVRiY2ZPcc/ygEAoLu/cWiLX 1ikn1f3I+sjGd68KiBoIMjDFFKyzmq3bQ+5POrEzwnsMOYUa7/2LEInTcexZGP63 7WVNdxQwrDyXUL6/2+7qH3x4c3fSBn0qWjY4oa7Z4YEa/0m5oS04E9ExmYB2LQ1G dvfYnyXJHBGmjJwa0UuypU726dIciuj+uEORTUYpIJVE+pWCdBqjVxUPtkhJakd1 xK8Ko2Q6ZUuSHmPjDIL+WVCSRXsd2Is3YZiDPNLiOrORq7cId10dPuuWWPuL9v0I JfwOm7KD8VWlOdbJb88b3ZoWj1PZ9QlkrwKapqkPDT3Mj2P8xXTb4zU30/yYGGhE 3BikSHqPFqDo3sd6f4TS =cc2f -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--