qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Richard Henderson <rth@twiddle.net>
Cc: Leon Alrae <Leon.Alrae@imgtec.com>,
	qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 14/15] tcg-mips: Use mipsr6 instructions in branches
Date: Wed, 10 Feb 2016 00:20:20 +0000	[thread overview]
Message-ID: <20160210002020.GD3678@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <20160209162234.GB3678@jhogan-linux.le.imgtec.org>

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

Hi Richard,

On Tue, Feb 09, 2016 at 04:22:34PM +0000, James Hogan wrote:
> (gdb) disas/r
> Dump of assembler code for function code_gen_buffer:
>    0x000000fff30b0064 <+0>:     f8 ff 11 8e     lw      s1,-8(s0)
> => 0x000000fff30b0068 <+4>:     08 00 11 60     bnezalc s1,0xfff30b008c <code_gen_buffer+40>

Note also that this seems to be the wrong encoding anyway. It is
encoding the "and-link" variation which overwrites $31 with PC+4.

Cheers
James


>    0x000000fff30b006c <+8>:     1d c0 c2 08     j       0xfff30b0074 <code_gen_buffer+16>
>    0x000000fff30b0070 <+12>:    00 00 00 00     nop
> 
> (gdb) set *0x000000fff30b006c=0
> (gdb) disas/r
> Dump of assembler code for function code_gen_buffer:
>    0x000000fff30b0064 <+0>:     f8 ff 11 8e     lw      s1,-8(s0)
> => 0x000000fff30b0068 <+4>:     08 00 11 60     bnezalc s1,0xfff30b008c <code_gen_buffer+40>
>    0x000000fff30b006c <+8>:     00 00 00 00     nop
>    0x000000fff30b0070 <+12>:    00 00 00 00     nop

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-02-10  0:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 10:39 [Qemu-devel] [PATCH 00/15] tcg mips64 and mipsr6 improvements Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 01/15] tcg-mips: Add mips64 opcodes Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 02/15] tcg-mips: Support 64-bit opcodes Richard Henderson
2016-02-09 15:24   ` James Hogan
2016-02-09 17:16     ` Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 03/15] tcg-mips: Adjust move functions for mips64 Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 04/15] tcg-mips: Adjust load/store " Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 05/15] tcg-mips: Adjust prologue " Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 06/15] tcg-mips: Add tcg unwind info Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 07/15] tcg-mips: Adjust qemu_ld/st for mips64 Richard Henderson
2016-02-10 16:34   ` James Hogan
2016-02-10 17:35     ` Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 08/15] tcg-mips: Adjust calling conventions " Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 09/15] tcg-mips: Fix exit_tb " Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 10/15] tcg-mips: Move bswap code to subroutines Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 11/15] tcg-mips: Use mips64r6 instructions in tcg_out_movi Richard Henderson
2016-02-09 16:50   ` James Hogan
2016-02-09 17:20     ` Richard Henderson
2016-02-09 17:25     ` Richard Henderson
2016-02-10  0:32     ` James Hogan
2016-02-09 10:40 ` [Qemu-devel] [PATCH 12/15] tcg-mips: Use mips64r6 instructions in tcg_out_ldst Richard Henderson
2016-02-09 10:40 ` [Qemu-devel] [PATCH 13/15] tcg-mips: Use mips64r6 instructions in constant addition Richard Henderson
2016-02-09 10:40 ` [Qemu-devel] [PATCH 14/15] tcg-mips: Use mipsr6 instructions in branches Richard Henderson
2016-02-09 16:22   ` James Hogan
2016-02-09 17:13     ` Richard Henderson
2016-02-09 18:46       ` Maciej W. Rozycki
2016-02-10  0:20     ` James Hogan [this message]
2016-02-09 10:40 ` [Qemu-devel] [PATCH 15/15] tcg-mips: Use mipsr6 instructions in calls Richard Henderson
2016-02-10 12:49   ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160210002020.GD3678@jhogan-linux.le.imgtec.org \
    --to=james.hogan@imgtec.com \
    --cc=Leon.Alrae@imgtec.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --subject='Re: [Qemu-devel] [PATCH 14/15] tcg-mips: Use mipsr6 instructions in branches' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox