From: Stefan Hajnoczi <stefanha@gmail.com>
To: Hollis Blanchard <hollis_blanchard@mentor.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in memory tracepoints
Date: Wed, 10 Feb 2016 10:11:48 +0000 [thread overview]
Message-ID: <20160210101148.GC7317@stefanha-x1.localdomain> (raw)
In-Reply-To: <56BA226B.7050602@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Tue, Feb 09, 2016 at 09:31:23AM -0800, Hollis Blanchard wrote:
> On 02/09/2016 07:53 AM, Stefan Hajnoczi wrote:
> >On Mon, Feb 08, 2016 at 04:03:05PM -0800, Hollis Blanchard wrote:
> >>-memory_region_ops_read(void *mr, uint64_t offset, uint64_t value, unsigned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> >>-memory_region_ops_write(void *mr, uint64_t offset, uint64_t value, unsigned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> >>+memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsigned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> >>+memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, unsigned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> >Please update the format string too ("offset" -> "addr").
>
> Oops, thanks. Do you want me to re-send the series, or just this patch?
I had no other comments and this is a small change so I can do it myself
when merging the patches. No need to resend.
Thanks,
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-10 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 0:03 [Qemu-devel] [PATCH 1/3] trace: docs: "simple" backend does support strings Hollis Blanchard
2016-02-09 0:03 ` [Qemu-devel] [PATCH 2/3] trace: split subpage MMIOs into their own trace events Hollis Blanchard
2016-02-09 0:03 ` [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in memory tracepoints Hollis Blanchard
2016-02-09 15:53 ` Stefan Hajnoczi
2016-02-09 17:31 ` Hollis Blanchard
2016-02-10 10:11 ` Stefan Hajnoczi [this message]
2016-02-10 10:14 ` [Qemu-devel] [PATCH 1/3] trace: docs: "simple" backend does support strings Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210101148.GC7317@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=hollis_blanchard@mentor.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).