From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTRkY-0002Pq-P1 for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:11:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTRkV-0005z2-Fg for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:11:54 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:35367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTRkV-0005yE-8l for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:11:51 -0500 Received: by mail-wm0-x231.google.com with SMTP id c200so20828324wme.0 for ; Wed, 10 Feb 2016 02:11:51 -0800 (PST) Date: Wed, 10 Feb 2016 10:11:48 +0000 From: Stefan Hajnoczi Message-ID: <20160210101148.GC7317@stefanha-x1.localdomain> References: <1454976185-30095-1-git-send-email-hollis_blanchard@mentor.com> <1454976185-30095-3-git-send-email-hollis_blanchard@mentor.com> <20160209155339.GB13149@stefanha-x1.localdomain> <56BA226B.7050602@mentor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TYecfFk8j8mZq+dy" Content-Disposition: inline In-Reply-To: <56BA226B.7050602@mentor.com> Subject: Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in memory tracepoints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hollis Blanchard Cc: pbonzini@redhat.com, qemu-devel@nongnu.org --TYecfFk8j8mZq+dy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 09, 2016 at 09:31:23AM -0800, Hollis Blanchard wrote: > On 02/09/2016 07:53 AM, Stefan Hajnoczi wrote: > >On Mon, Feb 08, 2016 at 04:03:05PM -0800, Hollis Blanchard wrote: > >>-memory_region_ops_read(void *mr, uint64_t offset, uint64_t value, unsi= gned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u" > >>-memory_region_ops_write(void *mr, uint64_t offset, uint64_t value, uns= igned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u" > >>+memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsign= ed size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u" > >>+memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, unsig= ned size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u" > >Please update the format string too ("offset" -> "addr"). >=20 > Oops, thanks. Do you want me to re-send the series, or just this patch? I had no other comments and this is a small change so I can do it myself when merging the patches. No need to resend. Thanks, Stefan --TYecfFk8j8mZq+dy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWuwzkAAoJEJykq7OBq3PI7gQH/RyJj1lHeWvHq+VbPoBkjl2x tK3oAYVFmkKCGvk0fYPeZlrU5XpcdeVoik9f4vDC7wgc95TGQJ+etyEXTvh41NDH fIZ/1HahVYduTgNILcimN0inRGjbpKvq/b7ie8jBzFnej21MFHaihR65jAzIiF/Q rj/m85a/l+eFApfC17O0AiptabRDmSKupLx6tTCgyWraCRdauUGvByh2VWlp247Z oIv/q5DRu16MlHDJ4Q/8sfQw4ngfjzV144cPBGOHkcTHhthoQoEpghh+B+/VsPwN 3gHn30SVC1dMrwhmjdTx/kc2TxC1Xh2f9JGxlVP900i2jRy5c1GgIJkrqnpHrXY= =jyKi -----END PGP SIGNATURE----- --TYecfFk8j8mZq+dy--