From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines
Date: Wed, 10 Feb 2016 21:26:12 +0100 [thread overview]
Message-ID: <20160210212612.07123ed3@bahia.huguette.org> (raw)
In-Reply-To: <20160208155947.11480.87951.stgit@bahia.huguette.org>
On Mon, 08 Feb 2016 16:59:47 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> Since QEMU 2.4, we have a configuration section in the migration stream.
> This must be skipped for older machines, like it is already done for x86.
>
Ouch ! It is more complex than I thought... the migration of pseries-2.3
machine is already broken between QEMU-2.3 and QEMU-2.4. So this patch
fixes indeed migration of a pseries-2.3 machine from QEMU-2.3, but it
breaks migration of the same machine from QEMU-2.4 and up.
Not sure how to deal with that... is it reasonable to assume that
pseries-2.3 running with QEMU-2.3 is the common case ? If so, this
patch would bring more help than harm.
> Fixes: 61964c23e5ddd5a33f15699e45ce126f879e3e33
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 5bd8fd3ef842..bca7cb8a5d27 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2446,6 +2446,7 @@ static void spapr_machine_2_3_instance_options(MachineState *machine)
> spapr_machine_2_4_instance_options(machine);
> savevm_skip_section_footers();
> global_state_set_optional();
> + savevm_skip_configuration();
> }
>
> static void spapr_machine_2_3_class_options(MachineClass *mc)
>
>
next prev parent reply other threads:[~2016-02-10 20:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 15:59 [Qemu-devel] [PATCH] spapr: skip configuration section during migration of older machines Greg Kurz
2016-02-10 13:54 ` [Qemu-devel] [Qemu-stable] " Greg Kurz
2016-02-10 14:20 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2016-02-10 20:26 ` Greg Kurz [this message]
2016-02-11 1:20 ` David Gibson
2016-02-11 16:53 ` Dr. David Alan Gilbert
2016-02-12 5:24 ` David Gibson
2016-02-12 11:14 ` Greg Kurz
2016-02-15 2:12 ` David Gibson
2016-02-15 11:02 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210212612.07123ed3@bahia.huguette.org \
--to=gkurz@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).