From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTf6I-0007rj-Hk for qemu-devel@nongnu.org; Wed, 10 Feb 2016 19:27:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTf6F-0000BS-C1 for qemu-devel@nongnu.org; Wed, 10 Feb 2016 19:27:14 -0500 Date: Thu, 11 Feb 2016 09:30:21 +1000 From: David Gibson Message-ID: <20160210233020.GE29288@voom.bne.redhat.com> References: <1455127752-17293-1-git-send-email-thuth@redhat.com> <1455127752-17293-2-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kA1LkgxZ0NN7Mz3A" Content-Disposition: inline In-Reply-To: <1455127752-17293-2-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/4] hw/ppc/spapr: Add h_set_sprg0 hypercall List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, laurent@vivier.eu --kA1LkgxZ0NN7Mz3A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 10, 2016 at 07:09:09PM +0100, Thomas Huth wrote: > This is a very simple hypercall that only sets up the SPRG0 > register for the guest (since writing to SPRG0 was only permitted > to the hypervisor in older versions of the PowerISA). >=20 > Signed-off-by: Thomas Huth > --- > hw/ppc/spapr_hcall.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c > index 12f8c33..58103ef 100644 > --- a/hw/ppc/spapr_hcall.c > +++ b/hw/ppc/spapr_hcall.c > @@ -332,6 +332,15 @@ static target_ulong h_read(PowerPCCPU *cpu, sPAPRMac= hineState *spapr, > return H_SUCCESS; > } > =20 > +static target_ulong h_set_sprg0(PowerPCCPU *cpu, sPAPRMachineState *spap= r, > + target_ulong opcode, target_ulong *args) > +{ > + CPUState *cs =3D CPU(cpu); > + > + set_spr(cs, SPR_SPRG0, args[0], -1L); This looks correct, but I think set_spr() is serious overkill here. It does some fancy synchronization designed for setting one cpu's SPR =66rom an hcall executed on a different CPU. In this case the calling CPU is just setting its own SPRG0, so just cpu_synchronize_state() env->spr[SPR_SPRG0] =3D XXX Should be sufficient. > + return H_SUCCESS; > +} > + > static target_ulong h_set_dabr(PowerPCCPU *cpu, sPAPRMachineState *spapr, > target_ulong opcode, target_ulong *args) > { > @@ -997,6 +1006,10 @@ static void hypercall_register_types(void) > spapr_register_hypercall(H_REGISTER_VPA, h_register_vpa); > spapr_register_hypercall(H_CEDE, h_cede); > =20 > + /* processor register resource access h-calls */ > + spapr_register_hypercall(H_SET_SPRG0, h_set_sprg0); > + spapr_register_hypercall(H_SET_MODE, h_set_mode); > + > /* "debugger" hcalls (also used by SLOF). Note: We do -not- differen= ciate > * here between the "CI" and the "CACHE" variants, they will use wha= tever > * mapping attributes qemu is using. When using KVM, the kernel will > @@ -1013,8 +1026,6 @@ static void hypercall_register_types(void) > /* qemu/KVM-PPC specific hcalls */ > spapr_register_hypercall(KVMPPC_H_RTAS, h_rtas); > =20 > - spapr_register_hypercall(H_SET_MODE, h_set_mode); > - > /* ibm,client-architecture-support support */ > spapr_register_hypercall(KVMPPC_H_CAS, h_client_architecture_support= ); > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --kA1LkgxZ0NN7Mz3A Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWu8gMAAoJEGw4ysog2bOS+Q4P/RpqbCuRR/NPVBHluHqxyFTx Nt6d/dU7nDLp4CtGPwvDz9/AzjjGBt454jE74rzm+3o0hp58nLwDC0o+ATFySwGx ZI024pT2hWsKDa91Ori1YF4RtB+X5zWbqKZknapvzJ9wOzueeCQl+4eX/7kKEPck ZHoXAJsCZwZutGBTv2bDr/u3qYTyHAe2BEHXg0GVspbRDoBeTcO13DQOZVJpl14T wXmnqjNIHoyOSqKAAB2taTnFDJO+MMQqsBa9RDyn+JfJFO6Cq7Rem8/Q7EDeiwBD 4QirQgFW6jdAEQBPi0tbJI+PVCCJROVHMaTm+NykZjsFpfnaE9gLPXHgC+KGrP2S rygWENIqrpJ7Ebf9FxjoLoBrcUQFy6kmeT62Yw6BQzJNdr6Tr/BRt2NA1TbUBVuP XKi+GPBD+YbyCRRex6KvGRtterBuCxjWcHJFgGUMqABScuWvj6hlVw2FSAjuzIAW NNzatqO6TED5gc19untPvpxMatrOnzr8iavpLmIWMiZYTttpRZEffy9Zd1ai8Hmm YGD3J06liUeI2EvM/cwceW4bAD+phdibDevvMZqtVwJFhlGmnIbN1T9GVe5EsNJE +HTBt+tkgVFCfc7tdfepTUtZLVdlttfyTWzKfPkwlRVOSEc3PSvMyVXYoxRETmej 1oVJykbciLmXPnCq7xt4 =dt6O -----END PGP SIGNATURE----- --kA1LkgxZ0NN7Mz3A--