From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTt2Q-0005lW-GS for qemu-devel@nongnu.org; Thu, 11 Feb 2016 10:20:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTt2P-0005lx-LX for qemu-devel@nongnu.org; Thu, 11 Feb 2016 10:20:10 -0500 Date: Thu, 11 Feb 2016 16:19:59 +0100 From: Igor Mammedov Message-ID: <20160211161959.7d939e7e@nial.brq.redhat.com> In-Reply-To: <1455136900-22334-4-git-send-email-somlo@cmu.edu> References: <1455136900-22334-1-git-send-email-somlo@cmu.edu> <1455136900-22334-4-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 3/5] acpi: pc: add fw_cfg device node to ssdt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: peter.maydell@linaro.org, ehabkost@redhat.com, mst@redhat.com, matt@codeblueprint.co.uk, stefanha@gmail.com, ard.biesheuvel@linaro.org, qemu-devel@nongnu.org, leif.lindholm@linaro.org, luto@amacapital.net, qemu-arm@nongnu.org, kraxel@redhat.com, pbonzini@redhat.com, lersek@redhat.com, rth@twiddle.net On Wed, 10 Feb 2016 15:41:38 -0500 "Gabriel L. Somlo" wrote: > Add a fw_cfg device node to the ACPI SSDT. While the guest-side > firmware can't utilize this information (since it has to access > the hard-coded fw_cfg device to extract ACPI tables to begin with), > having fw_cfg listed in ACPI will help the guest kernel keep a more > accurate inventory of in-use IO port regions. subj and commit msg: s/SSDT/DSDT/ >=20 > Signed-off-by: Gabriel Somlo > Reviewed-by: Laszlo Ersek > Reviewed-by: Marc Mar=C3=AD > --- > hw/i386/acpi-build.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) >=20 > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 4554eb8..4762fd2 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -2190,6 +2190,35 @@ build_dsdt(GArray *table_data, GArray *linker, > aml_append(scope, aml_name_decl("_S5", pkg)); > aml_append(dsdt, scope); > =20 > + /* create fw_cfg node, unconditionally */ Will that unconditionally make all Windows guests ask for driver for unknow= n device? > + { > + /* when using port i/o, the 8-bit data register *always* overlaps > + * with half of the 16-bit control register. Hence, the total si= ze > + * of the i/o region used is FW_CFG_CTL_SIZE; when using DMA, the > + * DMA control register is located at FW_CFG_DMA_IO_BASE + 4 */ > + uint8_t io_size =3D object_property_get_bool(OBJECT(pcms->fw_cfg= ), > + "dma_enabled", NULL) ? > + ROUND_UP(FW_CFG_CTL_SIZE, 4) + sizeof(dma_addr= _t) : > + FW_CFG_CTL_SIZE; > + > + scope =3D aml_scope("\\_SB"); > + dev =3D aml_device("FWCF"); > + > + aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002"))); > + > + /* device present, functioning, decoding, not shown in UI */ > + aml_append(dev, aml_name_decl("_STA", aml_int(0xB))); > + > + crs =3D aml_resource_template(); > + aml_append(crs, > + aml_io(AML_DECODE16, FW_CFG_IO_BASE, FW_CFG_IO_BASE, 0x01, i= o_size) > + ); > + aml_append(dev, aml_name_decl("_CRS", crs)); > + > + aml_append(scope, dev); > + aml_append(dsdt, scope); > + } > + > if (misc->applesmc_io_base) { > scope =3D aml_scope("\\_SB.PCI0.ISA"); > dev =3D aml_device("SMC");