qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: famz@redhat.com, John Snow <jsnow@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry object
Date: Fri, 12 Feb 2016 15:31:55 +0100	[thread overview]
Message-ID: <20160212143155.GE4828@noname.redhat.com> (raw)
In-Reply-To: <56B4FE80.3090202@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Am 05.02.2016 um 20:56 hat Eric Blake geschrieben:
> On 02/05/2016 11:12 AM, John Snow wrote:
> > Commit 16b0d555 introduced an issue where we are not initializing
> > has_filename for the 'next' MapEntry object, which leads to interesting
> > errors in Valgrind and Clang -fsanitize=undefined both.
> 
> grammar:
> 
> errors in both Valgrind and Clang -fsanitize=undefined.

Fixed up.

> > 
> > Zero the stack object at allocation AND make sure the utility to
> > populate the fields properly marks has_filename as false if applicable.
> > 
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > v2: Initialize with a compound literal as a future-proofing measure.
> > 
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks, applied to the block branch.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2016-02-12 14:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 18:12 [Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry object John Snow
2016-02-05 19:56 ` Eric Blake
2016-02-12 14:31   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160212143155.GE4828@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).