From: "Daniel P. Berrange" <berrange@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] broken HMP command: info mtree
Date: Fri, 12 Feb 2016 14:49:11 +0000 [thread overview]
Message-ID: <20160212144911.GI24725@redhat.com> (raw)
In-Reply-To: <20160212142723.53e31c6b@nial.brq.redhat.com>
On Fri, Feb 12, 2016 at 02:27:23PM +0100, Igor Mammedov wrote:
> On Fri, 12 Feb 2016 14:08:32 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> > On 12/02/2016 12:17, Daniel P. Berrange wrote:
> > > On Fri, Feb 12, 2016 at 12:15:26PM +0100, Igor Mammedov wrote:
> > >> On Thu, 11 Feb 2016 16:35:39 +0100
> > >> Igor Mammedov <imammedo@redhat.com> wrote:
> > >>
> > >>> executing 'info mtree' from monitor prompt causes infinite loop
> > >>> printing it over and over.
> > >>>
> > >>> to reproduce build current master adn run:
> > >>>
> > >>> qemu-system-x86_64 -monitor stdio
> > >>>
> > >>> and then execute 'info mtree' in monitor prompt
> > >>
> > >> it bisects to:
> > >>
> > >> commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2
> > >> Author: Daniel P. Berrange <berrange@redhat.com>
> > >> Date: Tue Jan 19 11:14:29 2016 +0000
> > >>
> > >> char: convert from GIOChannel to QIOChannel
> > >>
> > >> In preparation for introducing TLS support to the TCP chardev
> > >> backend, convert existing chardev code from using GIOChannel
> > >> to QIOChannel. This simplifies the chardev code by removing
> > >> most of the OS platform conditional code for dealing with
> > >> file descriptor passing.
> > >>
> > >> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> > >> Message-Id: <1453202071-10289-3-git-send-email-berrange@redhat.com>
> > >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > >>
> > >>
> > >> build with:
> > >> ./configure --target-list=x86_64-softmmu --enable-debug
> > >> on RHEL72ish host
> > >>
> > >> monitor output has to be stdio
> > >
> > > Sigh, so much pain from the chardev code. I'll investigate and send a
> > > suitable patch asap.
> >
> > Hmm, I cannot reproduce this though.
> Perhaps I'm affected because my stdout goes via remote ssh session.
>
> It looks like monitor tries to flush buffer but succeeds only partially
> and returns with EAGAIN and on the next flush attempt it tries to
> flush the same buffer again from the first byte again
Yes, it turned out to need a moderately slow console like a distant
ssh connection to trigger the EGAIN situation. I've just sent a patch.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
prev parent reply other threads:[~2016-02-12 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 15:35 [Qemu-devel] broken HMP command: info mtree Igor Mammedov
2016-02-12 11:15 ` Igor Mammedov
2016-02-12 11:17 ` Daniel P. Berrange
2016-02-12 13:08 ` Paolo Bonzini
2016-02-12 13:27 ` Igor Mammedov
2016-02-12 14:49 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212144911.GI24725@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).