From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42399)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aUFDF-0002U6-2c
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 10:00:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aUFDB-0000Gb-I0
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 10:00:48 -0500
Date: Fri, 12 Feb 2016 15:00:32 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160212150031.GJ24725@redhat.com>
References: <1455129674-17255-1-git-send-email-berrange@redhat.com>
	<20160212132833.GA15761@tesla.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160212132833.GA15761@tesla.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD
 server & client
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kashyap Chamarthy <kchamart@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Fri, Feb 12, 2016 at 02:28:33PM +0100, Kashyap Chamarthy wrote:
> On Wed, Feb 10, 2016 at 06:40:58PM +0000, Daniel P. Berrange wrote:
> 
> [...]
> 
> I've applied all the series in this patches, to yesterday's Git master,
> so I'm here:
> 
>     $ git describe
>     pull-qcrypto-next-2016-02-02-1-378-gf9375d2
> 
> > Starting a QEMU system emulator built-in NBD server
> > 
> >   $ qemu-system-x86_64 \
> >      -qmp unix:/tmp/qmp,server \
> >      -hda /home/berrange/Fedora-Server-netinst-x86_64-23.iso \
> >      -object tls-creds-x509,id=tls0,dir=/home/berrange/security/qemutls,endpoint=server
> 
> Instead of an ISO, I have this command-line:
> 
>     $QEMU \
>       -display none \
>       -nodefconfig \
>       -nodefaults \
>       -m 2048 \
>       -device virtio-scsi-pci,id=scsi \
>       -device virtio-serial-pci \
>       -serial stdio \
>       -drive file=./cirros-0.3.3.qcow2,format=qcow2,if=virtio \
>       -object tls-creds-x509,id=tls0,dir=/export/security/gnutls,endpoint=server \
>       -qmp unix:./qmp-sock,server
> 
> >   $ qmp-shell /tmp/qmp
> >      (qmp) nbd-server-start addr={"host":"localhost","port":"9000"}
> >      tls-creds=tls0
> 
> However, this invocation seem to work for me, am I doing something wrong?
> 
>     $ ./qmp-shell ./qmp-sock
>     Welcome to the QMP low-level shell!
>     Connected to QEMU 2.5.50
>   
>     (QEMU) nbd-server-start addr={'host:'localhost','port':'9000'} tls-creds=tls0
>     {"error": {"class": "GenericError", "desc": "Invalid parameter type for 'addr', expected: QDict"}}
>     (QEMU)

Yes, my bad - I provided the wrong syntax here. it should be

  (QEMU) nbd-server-start addr={"type":"inet","data":{"host":"localhost","port":"9000"}} tls-creds=tls0
  {"return": {}}
  (QEMU) nbd-server-add device=ide0-hd0
  {"return": {}}

I've genuinely tested it this time :-)

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|