From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kchamart@redhat.com>) id 1aUGBg-0003DQ-Tz
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 11:03:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kchamart@redhat.com>) id 1aUGBg-0005B3-1f
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 11:03:16 -0500
Date: Fri, 12 Feb 2016 17:03:07 +0100
From: Kashyap Chamarthy <kchamart@redhat.com>
Message-ID: <20160212160307.GM31194@tesla.redhat.com>
References: <1455129674-17255-1-git-send-email-berrange@redhat.com>
	<20160212132833.GA15761@tesla.redhat.com>
	<20160212150031.GJ24725@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160212150031.GJ24725@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD
 server & client
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Fri, Feb 12, 2016 at 03:00:32PM +0000, Daniel P. Berrange wrote:
> On Fri, Feb 12, 2016 at 02:28:33PM +0100, Kashyap Chamarthy wrote:
> > On Wed, Feb 10, 2016 at 06:40:58PM +0000, Daniel P. Berrange wrote:
> > 
> > [...]
> > 
> > I've applied all the series in this patches, 

s/series in this patches/patches in this series/

> > to yesterday's Git master,
> > so I'm here:
> > 
> >     $ git describe
> >     pull-qcrypto-next-2016-02-02-1-378-gf9375d2
> > 

[...]

> > >   $ qmp-shell /tmp/qmp
> > >      (qmp) nbd-server-start addr={"host":"localhost","port":"9000"}
> > >      tls-creds=tls0
> > 
> > However, this invocation seem to work for me, am I doing something

Typo: s/seem to work/doesn't seem to work/

> > wrong?

> > 
> >     $ ./qmp-shell ./qmp-sock
> >     Welcome to the QMP low-level shell!
> >     Connected to QEMU 2.5.50
> >   
> >     (QEMU) nbd-server-start addr={'host:'localhost','port':'9000'} tls-creds=tls0
> >     {"error": {"class": "GenericError", "desc": "Invalid parameter type for 'addr', expected: QDict"}}
> >     (QEMU)
> 
> Yes, my bad - I provided the wrong syntax here. it should be
> 
>   (QEMU) nbd-server-start addr={"type":"inet","data":{"host":"localhost","port":"9000"}} tls-creds=tls0
>   {"return": {}}
>   (QEMU) nbd-server-add device=ide0-hd0
>   {"return": {}}
> 
> I've genuinely tested it this time :-)

Heh, right, this works.  I should've figured this out, given that I've
already used it in the complete JSON invocation in my previous email.

    [...] "addr":{"type":"inet","data":{"host":"localhost","port":"9000"}}[...]


So, 'qmp-shell' invocation works for me too:

    $ ./qmp-shell ./qmp-sock
    [...]
    (QEMU) nbd-server-start addr={"type":"inet","data":{"host":"localhost","port":"9000"}} tls-creds=tls0
    {"return": {}}
    (QEMU)
    (QEMU) nbd-server-add device=virtio0
    {"return": {}}
    (QEMU)

-- 
/kashyap