From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kchamart@redhat.com>) id 1aUIEn-0007Yf-5h
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 13:14:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kchamart@redhat.com>) id 1aUIEm-0005sy-41
	for qemu-devel@nongnu.org; Fri, 12 Feb 2016 13:14:36 -0500
Date: Fri, 12 Feb 2016 19:14:28 +0100
From: Kashyap Chamarthy <kchamart@redhat.com>
Message-ID: <20160212181428.GB15761@tesla.redhat.com>
References: <1455129674-17255-1-git-send-email-berrange@redhat.com>
	<20160212132833.GA15761@tesla.redhat.com>
	<20160212150031.GJ24725@redhat.com>
	<20160212160307.GM31194@tesla.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160212160307.GM31194@tesla.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD
 server & client
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Fri, Feb 12, 2016 at 05:03:07PM +0100, Kashyap Chamarthy wrote:

[...]

> So, 'qmp-shell' invocation works for me too:
> 
>     $ ./qmp-shell ./qmp-sock
>     [...]
>     (QEMU) nbd-server-start addr={"type":"inet","data":{"host":"localhost","port":"9000"}} tls-creds=tls0
>     {"return": {}}
>     (QEMU)
>     (QEMU) nbd-server-add device=virtio0
>     {"return": {}}
>     (QEMU)
> 

Noting so I can remember in future, thanks to commit 1ceca07 ("scripts:
qmp-shell: Add verbose flag"), if I supply '-v' flag to 'qmp-shell', it
will conveniently print out the full QMP command-line it constructed:

    $ ./qmp-shell -v /var/tmp/qmp-sock
    [...]
    (QEMU) nbd-server-start addr={"type":"inet","data":{"host":"localhost","port":"9000"}} tls-creds=tls0
    {"execute": "nbd-server-start", "arguments": {"addr": {"data": {"host": "localhost", "port": "9000"}, "type": "inet"}, "tls-creds": "tls0"}}
    {"return": {}}
    (QEMU) nbd-server-add device=virtio0
    {"execute": "nbd-server-add", "arguments": {"device": "virtio0"}}
    {"return": {}}
    (QEMU) nbd-server-stop
    {"execute": "nbd-server-stop", "arguments": {}}
    {"return": {}}
    (QEMU) 

-- 
/kashyap