From: David Gibson <david@gibson.dropbear.id.au>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-ppc@nongnu.org, "Alyssa Milburn" <fuzzie@fuzzie.org>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-devel@nongnu.org, "Alexander Graf" <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 00/13] cuda: misc fixes and cleanups
Date: Mon, 15 Feb 2016 11:25:32 +1100 [thread overview]
Message-ID: <20160215002532.GK2732@voom.fritz.box> (raw)
In-Reply-To: <56C0CF1C.4010006@ilande.co.uk>
[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]
On Sun, Feb 14, 2016 at 07:01:48PM +0000, Mark Cave-Ayland wrote:
> On 07/02/16 20:34, Hervé Poussineau wrote:
>
> > Hi,
> >
> > This patchset cleans up a little bit the Apple CUDA emulation:
> > - correctly reject commands with wrong parameters
> > - support changing the frequency of auto-polling
> > - support changing device list probed in auto-poll
> > - add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE
> > - remove unused commands (GET/SET_6805_ADDR)
> > - remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC
> >
> > GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once
> > we implement the I2C bus provided by CUDA.
> >
> > Hervé
> >
> > Hervé Poussineau (13):
> > cuda: add a framework to handle commands
> > cuda: move unknown commands reject out of switch
> > cuda: port AUTOPOLL command to new framework
> > cuda: port SET_AUTO_RATE command to new framework
> > cuda: port SET_DEVICE_LIST command to new framework
> > cuda: port POWERDOWN command to new framework
> > cuda: port RESET_SYSTEM command to new framework
> > cuda: port FILE_SERVER_FLAG command to new framework
> > cuda: port SET_POWER_MESSAGES command to new framework
> > cuda: port GET_TIME command to new framework
> > cuda: port SET_TIME command to new framework
> > cuda: remove GET_6805_ADDR command
> > cuda: remove CUDA_GET_SET_IIC/CUDA_COMBINED_FORMAT_IIC commands
> >
> > hw/input/adb.c | 18 ++--
> > hw/misc/macio/cuda.c | 279 ++++++++++++++++++++++++++++++++++++-------------
> > hw/ppc/mac.h | 2 +
> > include/hw/input/adb.h | 2 +-
> > 4 files changed, 217 insertions(+), 84 deletions(-)
>
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>
> This looks good to me, and again passes all my local tests. The only
> thing I noticed was that there were no changes related to
> qemu_log_mask() as per David's comments on patch 2 but other than that I
> think this patchset is fine to merge for 2.6.
Thanks for this, I've merged the series to ppc-for-2.6.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-02-15 0:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 20:34 [Qemu-devel] [PATCH v2 00/13] cuda: misc fixes and cleanups Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 01/13] cuda: add a framework to handle commands Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 02/13] cuda: move unknown commands reject out of switch Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 03/13] cuda: port AUTOPOLL command to new framework Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 04/13] cuda: port SET_AUTO_RATE " Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 05/13] cuda: port SET_DEVICE_LIST " Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 06/13] cuda: port POWERDOWN " Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 07/13] cuda: port RESET_SYSTEM " Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 08/13] cuda: port FILE_SERVER_FLAG " Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 09/13] cuda: port SET_POWER_MESSAGES " Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 10/13] cuda: port GET_TIME " Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 11/13] cuda: port SET_TIME " Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 12/13] cuda: remove GET_6805_ADDR command Hervé Poussineau
2016-02-07 20:34 ` [Qemu-devel] [PATCH v2 13/13] cuda: remove CUDA_GET_SET_IIC/CUDA_COMBINED_FORMAT_IIC commands Hervé Poussineau
2016-02-14 19:01 ` [Qemu-devel] [PATCH v2 00/13] cuda: misc fixes and cleanups Mark Cave-Ayland
2016-02-14 20:07 ` Hervé Poussineau
2016-02-15 0:25 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215002532.GK2732@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=fuzzie@fuzzie.org \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).