qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.a@redhat.com>,
	John Snow <jsnow@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/4] pc/q35: drop compatiility with old bios types
Date: Mon, 15 Feb 2016 13:20:50 -0200	[thread overview]
Message-ID: <20160215152050.GO6239@thinpad.lan.raisama.net> (raw)
In-Reply-To: <20160215132645-mutt-send-email-mst@redhat.com>

On Mon, Feb 15, 2016 at 01:30:49PM +0200, Michael S. Tsirkin wrote:
> On Mon, Feb 15, 2016 at 11:58:24AM +0100, Gerd Hoffmann wrote:
> > On So, 2016-02-07 at 12:29 +0200, Michael S. Tsirkin wrote:
> > > We don't ship bios without support for loading ACPI anymore, and old q35
> > > machine types don't allow migrating such bios.  Drop it, as well as
> > > has_*mr flags that are there for migration compatibility.
> > 
> > Wouldn't that break migration between 2.5 and 2.6 with -M q35-1.6 ?
> 
> I think I said this somewhere but I'll repeat it here: I think we should
> just mark the old machine types non migrateable.

If you are making changes that break migration, I believe you
need to mark the machines as non-migratable before making those
changes.

...or we could stop wasting time changing those old machines and
remove them.

-- 
Eduardo

  reply	other threads:[~2016-02-15 15:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-07 10:29 [Qemu-devel] [PATCH 0/4] pc: drop AML files Michael S. Tsirkin
2016-02-07 10:29 ` [Qemu-devel] [PATCH 1/4] pc/piix: drop acpi-dsdt.aml Michael S. Tsirkin
2016-02-07 10:29 ` [Qemu-devel] [PATCH 2/4] pc/q35: drop compatiility with old bios types Michael S. Tsirkin
2016-02-15 10:58   ` Gerd Hoffmann
2016-02-15 11:30     ` Michael S. Tsirkin
2016-02-15 15:20       ` Eduardo Habkost [this message]
2016-02-15 14:16     ` Markus Armbruster
2016-02-07 10:29 ` [Qemu-devel] [PATCH 3/4] pc/q35: drop dsdt aml Michael S. Tsirkin
2016-02-07 10:29 ` [Qemu-devel] [PATCH 4/4] configure: don't install aml links Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160215152050.GO6239@thinpad.lan.raisama.net \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).