From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVUEX-0005jz-VP for qemu-devel@nongnu.org; Mon, 15 Feb 2016 20:15:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVUET-0005KW-5D for qemu-devel@nongnu.org; Mon, 15 Feb 2016 20:15:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVUES-0005KN-Tq for qemu-devel@nongnu.org; Mon, 15 Feb 2016 20:15:13 -0500 Date: Tue, 16 Feb 2016 09:15:06 +0800 From: Fam Zheng Message-ID: <20160216011506.GA18664@ad.usersys.redhat.com> References: <1454664263-25969-1-git-send-email-famz@redhat.com> <1454664263-25969-7-git-send-email-famz@redhat.com> <87wpq6m490.fsf@linaro.org> <87si0um3fc.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <87si0um3fc.fsf@linaro.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/12] docker: Add basic test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Alex =?iso-8859-1?Q?Benn=E9e?= Cc: Kevin Wolf , Stefan Weil , QEMU Developers , Stefan Hajnoczi , Paolo Bonzini , John Snow , David Gibson On Mon, 02/15 14:52, Alex Benn=E9e wrote: >=20 > Peter Maydell writes: >=20 > > On 15 February 2016 at 14:34, Alex Benn=E9e = wrote: > >> > >> Fam Zheng writes: > >>> +cd $(mktemp -d) > >>> +mkdir build > >>> +mkdir install > >>> +cd build > >>> +build_qemu --target-list=3Dx86_64-softmmu --prefix=3D"${pwd}/insta= ll" > > > > Why restrict the target list ? There is no particular reason, just I wanted to keep the "basic test" bas= ic. I'll rename it to "quick". That said, this is only one of many possible tests, multiplied by the num= ber of images we ship. We need to be careful with the matrix, because the point = of having these tests is to run them frequently (either manually by develope= rs or automatically by CI on every patch series or even every patch). 10+ minut= es for a single test/image combination just makes that hard. > > > >>> +make check $MAKEFLAGS > >>> +make install > >> > >> From my excursions last week into the tests directory I discovered t= he > >> unit tests are built for a number of different qtest binaries. For > >> completeness we should probably include the whole list: > >> > >> #+name: qtest-targets > >> #+begin_src sh :dir ~/lsrc/qemu/qemu.git :results scalar > >> grep -E "check-qtest-[[:alnum:]]+-y " tests/Makefile | cut -d " " -f= 1 | sort -u > >> #+end_src > >> > >> #+RESULTS: qtest-targets > >> #+begin_example > >> check-qtest-arm-y > >> check-qtest-generic-y > >> check-qtest-i386-y > >> check-qtest-ipack-y > >> check-qtest-microblazeel-y > >> check-qtest-mips64el-y > >> check-qtest-mips64-y > >> check-qtest-mips-y > >> check-qtest-pci-y > >> check-qtest-ppc64-y > >> check-qtest-ppc-y > >> check-qtest-sh4eb-y > >> check-qtest-sh4-y > >> #check-qtest-sparc64-y > >> check-qtest-sparc64-y > >> #check-qtest-sparc-y > >> check-qtest-virtioserial-y > >> check-qtest-virtio-y > >> check-qtest-x86_64-y > >> check-qtest-xtensaeb-y > >> check-qtest-y > >> #+end_example > > > > I'm having difficulty figuring out what you're proposing here, > > but it looks like you're suggesting listing all the check-qtest-* > > test names again here, which seems worth avoiding. We should > > just do a build and make check and let that take care of > > running all the tests. >=20 > Well there is a halfway house between building one target and building > all possible targets. Not all the softmmu targets include additional > tests. Having said that it is probably simpler as you say to just build > everything. Sure, but I'd create a separate "full" test for that. Fam