From: Amit Shah <amit.shah@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context
Date: Thu, 18 Feb 2016 10:47:02 +0530 [thread overview]
Message-ID: <20160218051702.GA4440@grmbl.mre> (raw)
In-Reply-To: <1455259174-3384-1-git-send-email-den@openvz.org>
Can someone from the block team please give this a review?
Thanks,
On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote:
> There is a possibility to hit an assert in qcow2_get_specific_info that
> s->qcow_version is undefined. This happens when VM in starting from
> suspended state, i.e. it processes incoming migration, and in the same
> time 'info block' is called.
>
> The problem is that qcow2_invalidate_cache() closes the image and
> memset()s BDRVQcowState in the middle.
>
> This operation should not be performed in coroutine context.
>
> Changes from v1:
> - fixed spelling. Eric, thank you for spell checking
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Amit Shah <amit.shah@redhat.com>
>
Amit
next prev parent reply other threads:[~2016-02-18 5:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 6:39 [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context Denis V. Lunev
2016-02-12 6:39 ` [Qemu-devel] [PATCH 1/2] migration: move bdrv_invalidate_cache_all of " Denis V. Lunev
2016-02-23 12:54 ` Fam Zheng
2016-02-12 6:39 ` [Qemu-devel] [PATCH 2/2] " Denis V. Lunev
2016-02-12 12:50 ` Dr. David Alan Gilbert
2016-02-12 12:55 ` Paolo Bonzini
2016-02-12 16:25 ` Denis V. Lunev
2016-02-16 5:56 ` [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out " Denis V. Lunev
2016-02-18 5:17 ` Amit Shah [this message]
2016-02-18 8:03 ` Denis V. Lunev
2016-02-18 14:54 ` Paolo Bonzini
2016-02-22 9:32 ` Amit Shah
2016-02-22 9:01 ` Denis V. Lunev
2016-02-23 7:39 ` Amit Shah
2016-02-23 10:47 ` Amit Shah
2016-02-23 12:39 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218051702.GA4440@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).