From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36288)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aaiwt-0004zm-Eu
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 06:58:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aaiwq-0001ve-ML
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 06:58:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aaiwq-0001ut-HJ
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 06:58:40 -0500
Date: Tue, 1 Mar 2016 11:58:36 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160301115836.GI26728@redhat.com>
References: <56BCCB44.4060203@redhat.com>
	<1455795518-19205-1-git-send-email-dimara@arrikto.com>
	<1456830921.23994.14.camel@redhat.com>
	<20160301114707.GG26728@redhat.com> <56D58227.1080408@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <56D58227.1080408@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if
	deamonized
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Dimitris Aragiorgis <dimara@arrikto.com>

On Tue, Mar 01, 2016 at 12:51:03PM +0100, Paolo Bonzini wrote:
> 
> 
> On 01/03/2016 12:47, Daniel P. Berrange wrote:
> > means that QEMU will never close stderr anymore, so libvirt things
> > QEMU is still starting up....forever.
> > 
> > Given current libvirt behaviour / expectations, I think the only
> > option is to revert this change.
> 
> Why not fix it instead? :)

Because if the user upgrades QEMU it'll cause all existing deployed
version of libvirt to hang. I think that's pretty undesirable
behaviour.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|