From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aakkt-0000TU-Eb for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:54:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aakkp-0000qF-NO for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:54:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aakkp-0000pt-IO for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:54:23 -0500 Date: Tue, 1 Mar 2016 13:54:18 +0000 From: "Daniel P. Berrange" Message-ID: <20160301135418.GJ26728@redhat.com> References: <56BCCB44.4060203@redhat.com> <1455795518-19205-1-git-send-email-dimara@arrikto.com> <1456830921.23994.14.camel@redhat.com> <20160301114707.GG26728@redhat.com> <56D58227.1080408@redhat.com> <20160301115836.GI26728@redhat.com> <56D5852C.9050400@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56D5852C.9050400@redhat.com> Subject: Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Dimitris Aragiorgis On Tue, Mar 01, 2016 at 01:03:56PM +0100, Paolo Bonzini wrote: > > > On 01/03/2016 12:58, Daniel P. Berrange wrote: > > > > means that QEMU will never close stderr anymore, so libvirt things > > > > QEMU is still starting up....forever. > > > > > > > > Given current libvirt behaviour / expectations, I think the only > > > > option is to revert this change. > > > > > > Why not fix it instead? :) > > > > Because if the user upgrades QEMU it'll cause all existing deployed > > version of libvirt to hang. I think that's pretty undesirable > > behaviour. > > Let me rephrase, why not fix it in QEMU? Jan Tomko helped me debugging > it, and I've sent a patch just before seeing your message. Oh, we were talking with crossed wires. Yes, fixing the problem rather than fully reverting the patch is of course a reasonable solution. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|