From: Samuel Thibault <samuel.thibault@gnu.org>
To: Maxim Samoylov <max7255@yandex-team.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC 1/4] slirp: add helper for tcp6 socket creation
Date: Tue, 30 Oct 2018 17:00:09 +0100 [thread overview]
Message-ID: <20181030160009.faxqtyhssmous52t@function> (raw)
In-Reply-To: <4e542b8d-c273-c473-379c-887af2df6473@yandex-team.ru>
Maxim Samoylov, le mar. 30 oct. 2018 16:58:17 +0300, a ecrit:
> On 27.10.2018 14:11, Samuel Thibault wrote:
> > Is there a reason why you set SO_OOBINLINE, but not TCP_NODELAY? That's
> > the kind of discrepancy we don't want to let unseen, thus the reason for
> > a shared implementation :)
>
> Actually my code was initially based on the last year master state, so I
> missed your changes on TCP_NODELAY while rebasing
Which shows why it's useful to share the code :)
Samuel
next prev parent reply other threads:[~2018-10-30 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 0:03 [Qemu-devel] [PATCH RFC 0/4] slirp: support hostfwd for ipv6 addresses Maxim Samoylov
2018-10-26 0:03 ` [Qemu-devel] [PATCH RFC 1/4] slirp: add helper for tcp6 socket creation Maxim Samoylov
2018-10-27 11:11 ` Samuel Thibault
2018-10-27 11:13 ` Samuel Thibault
2018-10-30 13:58 ` Maxim Samoylov
2018-10-30 16:00 ` Samuel Thibault [this message]
2018-10-26 0:03 ` [Qemu-devel] [PATCH RFC 2/4] slirp: add helper for udp6 " Maxim Samoylov
2018-10-27 11:13 ` Samuel Thibault
2018-10-26 0:03 ` [Qemu-devel] [PATCH RFC 3/4] slirp: add helpers for ipv6 hostfwd manipulation Maxim Samoylov
2018-10-27 11:23 ` Samuel Thibault
2018-10-26 0:03 ` [Qemu-devel] [PATCH RFC 4/4] net/slirp: add ipv6-hostfwd option for user netdev type Maxim Samoylov
2018-10-26 6:14 ` Thomas Huth
2018-10-30 14:00 ` Maxim Samoylov
2018-10-27 11:38 ` Samuel Thibault
2018-11-05 23:05 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030160009.faxqtyhssmous52t@function \
--to=samuel.thibault@gnu.org \
--cc=max7255@yandex-team.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).