From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Caio Carrara" <ccarrara@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Fam Zheng" <famz@redhat.com>, "Cleber Rosa" <crosa@redhat.com>
Subject: [Qemu-devel] [PATCH 2/4] check-venv: use recorded Python version
Date: Fri, 9 Nov 2018 10:07:08 -0500 [thread overview]
Message-ID: <20181109150710.31085-3-crosa@redhat.com> (raw)
In-Reply-To: <20181109150710.31085-1-crosa@redhat.com>
The current approach works fine, but it runs Python on every make
command (even if it's not related to the venv usage).
This is just an optimization, and not a change of behavior.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/Makefile.include | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 074eece558..c0a341c923 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -913,8 +913,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results
# information please refer to "avocado --help".
AVOCADO_SHOW=none
-PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >= (3, 0) else 0)')
-ifeq ($(PYTHON3), 1)
+ifneq ($(findstring v2,"v$(PYTHON_VERSION)"),v2)
$(TESTS_VENV_DIR): $(TESTS_VENV_REQ)
$(call quiet-command, \
$(PYTHON) -m venv --system-site-packages $@, \
--
2.19.1
next prev parent reply other threads:[~2018-11-09 15:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 15:07 [Qemu-devel] [PATCH 0/4] Record Python version and misc test/CI fixes Cleber Rosa
2018-11-09 15:07 ` [Qemu-devel] [PATCH 1/4] configure: keep track of Python version Cleber Rosa
2018-11-09 15:49 ` Eduardo Habkost
2018-11-09 16:39 ` Cleber Rosa
2018-11-09 18:25 ` Eduardo Habkost
2018-11-09 19:09 ` Cleber Rosa
2018-11-09 19:51 ` Cleber Rosa
2018-11-09 21:25 ` Eduardo Habkost
2018-11-09 21:26 ` Eduardo Habkost
2019-08-22 16:48 ` Peter Maydell
2019-08-22 21:19 ` Cleber Rosa
2019-08-22 21:54 ` Eduardo Habkost
2019-08-23 13:40 ` Cleber Rosa
2019-08-23 13:44 ` Peter Maydell
2019-08-23 17:42 ` Cleber Rosa
2019-08-23 15:04 ` Eduardo Habkost
2019-08-23 17:44 ` Cleber Rosa
2018-11-09 15:07 ` Cleber Rosa [this message]
2018-11-09 21:27 ` [Qemu-devel] [PATCH 2/4] check-venv: use recorded " Eduardo Habkost
2018-11-09 15:07 ` [Qemu-devel] [PATCH 3/4] Travis CI: make specified Python versions usable on jobs Cleber Rosa
2018-11-09 15:52 ` Alex Bennée
2018-11-12 16:25 ` Eduardo Habkost
2018-11-09 19:34 ` Philippe Mathieu-Daudé
2018-11-09 19:39 ` Cleber Rosa
2018-11-12 16:23 ` Eduardo Habkost
2018-11-12 17:38 ` Cleber Rosa
2018-11-09 15:07 ` [Qemu-devel] [PATCH 4/4] check-help: visual and content improvements Cleber Rosa
2018-11-09 16:43 ` Eric Blake
2018-11-09 19:32 ` Philippe Mathieu-Daudé
2018-11-09 21:29 ` Eduardo Habkost
2018-11-12 17:51 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109150710.31085-3-crosa@redhat.com \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ccarrara@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).